Blender Git Loki

Yet another commit to get rid of missing faces in fill brushes.

We are now guarding against some divisions by small values.
There are still issues here but they are not on boundary faces
anymore so they must be related to some other issue such as
the triangle intersection test.

Sequencer: allow scene volume above 1

Fix T43651: New pointiness attribute doesn't work with displacement

Simple fix: just make pointiness aware of bump offset.

Fix T43739: bad documentation for bmesh py `intersect_face_point()`

Previous text could make think this func was checking whether a point was
inside and on the face, while it actually checks whether the projection
of that point onto the face is inside its boundary...

RNA: correct bool callbacks

Revert "Cast result of rna_RenderSettings_use_game_engine_get to {0, 1}"

There are more flags that trigger this assertion, so I want to discuss
an appropriate way to fix it before changing them all.

This reverts commit b1191e5caf1a888bfad2185ed41db2e91fbf46e2.

Cast result of rna_RenderSettings_use_game_engine_get to {0, 1}

rna_RenderSettings_use_game_engine_get() in rna_scene.c would return 0 or 2,
whereas the assertion in rna_access.c:1843 indicates that boolean values
should only be 0 or 1.

RNA: calloc -> malloc when fixbuf is uninitialized

Fix for unlikely NULL pointer dereference

Potential crash reading freestyle modifiers from future blend-files

Fix possible (unlikely) memory leak

Cycles: Use size_t for aligned allocator

Seems it got changes by accident to int during guarded allocation work,
causing bad memory allocations.

Skip flip check in cases where it's not needed.

Remove flipping for colinear case/ In such cases it is doubtful whether
face orientation is really meaningful

Projective painting: Only dither if factor is more than zero

Fix T43735 painting on perpendicular to the screen polygons is
problematic (still!)

It seems due to floating point precision issues we have to account for
even more cases.

Added colinear check for one more triangle edge-vertex and assumed that
if no collision test is found then triangle is completely inside box.

Such cases are mostly from float precision not catching triangle just
outside bucket. Now tests are much better for simple tests (paint/flood
fill cube from ortho view, paint sphere), however there are still some
rare cases of stray pixels.

Cycles: Cleanup for indentation in device_cpu.cpp

Perhaps became broken after rather recent change about which entry point
to kernel to use.

Cycles: Free memory used by intermediate BVH vectors earlier

Ideally we should get rid of those temporary vectors anyway, but
it's not so trivial because of the alignment. For untl then we'll
just have a bit worse solution. This part of code is not the root
of the issue of memory spikes for now anyway.

But since we're getting rid of temporary memory earlier actual spike
is a bit smaller as now. For example in franck_sheep file it's now
5489.69MB vs. previously 5599.90MB.

Cycles: Reduce memory used by background light update

Simple change: just get rid of intermediate data a bit earlier, before
final pixels array is being allocated. This gives around 30% of memory
save during light update (this is about 60meg in the frank sheep file
i'm using here).

This isn't really visible by artists a lot, because actual spike happens
on BVH construction. But it doesn't mean we shouldn't be accurate with
memory usage in other areas.

Cleanup: Restructure curve settings code a bit.

This is a bit more logical, as it better represents the 3 primitive types we have.

Fix 2d paint issue with textured brushes: Multiply brush color with
texture in the right space