Blender Git Loki

fix for error loading ruler info back from greasepencil.

ruler:
- initial ruler point snaps by default now.
- header text drawing was delayed until the first point was added.

Bug report #34573

User Preferences, Themes, UI: buttons to define own icon image now draws
greyed out, to show the option isn't working yet.

Fix #34562, leftover from own coordinate conversion refactoring. Also
avoid extraneous OpenGL state chage.

ruler:
- show header text for keyshortcuts.
- add Ctrl+C to copy the active ruler value.

code cleanup: use '%.*d' with string formatting for variable length number.

Improvements to addon-prefs key search suggested by Yang Niren.
- add accent_grave.
- strip the search string.
- add numpad numbers (currently these match regular numbers).

also remove unneeded forward declarations in path_util.c

patch [#34586] Variable typo in glaDrawPixelsTexScaled
from Andre D (andred)

xzoom was used where yzoom was meant to be used. Caused issues when xzoom and yzoom were not the same value.

code cleanup:

- remove unused block from before blender was opensourced (BKE_library_make_local)
noticed by Lawrence D'Oliveiro (ldo)
- remove text_idbutton() unused function.
- test_idbutton(name) was taking (name + 2), then checking 2 bytes before the pointer, this is error prone so better just take the name including the ID prefix.

add STREQ macro (commonly used macro like CLAMP, MAX2, STRINGIFY). Use for some areas of the python api, bmesh.

patch [#34103] check_for_dupid2.patch
from Lawrence D'Oliveiro (ldo)

check_for_dupid comments:
- correct comment about in_use array
- note name-truncation code will never be executed
---

Added asserts to ensure comments are correct - ideasman42.

patch [#34103] check_for_dupid.patch
from Lawrence D'Oliveiro (ldo)

- more comments
- more uses of bool type
- define symbol for length of in_use array in check_for_dupid

style cleanup: whitespace

patch [#34103] path_util_split_name_num.patch
from Lawrence D'Oliveiro (ldo)

Simplify implementation of BLI_split_name_num

- With some changes of my own to avoid second call to strlen()

patch [#34103] path_util_cleanup_path.patch
from Lawrence D'Oliveiro

Improve implementation of BLI_cleanup_path, including making it behave as documented.

"/../home/me" would become "home/me" rather then "/home/me"

Also remove redundant BLI_strncpy()

* Cleanup: collapse unneeded paint 2d function to the caller. Also, new
code now does not use painter_2d_paint at all. Made sure the approprate
variables of painter_2d are still initialized (They may be refactored to
become part of the ImagePaintState struct)

* Enable pressure control for new code path in texture paint. This revealed a bug, also present in blender 2.66: Size pressure is broken.
This was pretty interesting for me because it indicates that we could support
dynamic size in texture paint: (See anchored brushes)

Time to start reaping the benefits of code unification. Support for
pressure spacing across all paint systems (was supported only for
texture painting earlier). Also, switch paint code to use the new code
path from now on. No shift-Lclick required anymore.

Cycles / OSL:
* More small improvements: return immediately, and use "else if".

Cycles / OSL:
* Avoid some conditional branches for the Noise texture and return immediately.

code cleanup: make bmesh var names more consistent