Blender Git Loki

Cleanup: use ELEM macro (>2 args)

Cleanup: clang-format

Missed this last commit.

Cleanup: use ELEM macro

Cleanup: follow our code style for float literals

Cleanup: use bool argument in BLI_noise

Cleanup: BLI_noise

Use common prefix as this collided with existing API's (eg BLI_voronoi).

Also expand some non-obvious abbreviations:

- 'g' -> 'generic'
- 'vl' -> 'variable_lacunarity'
- 'V' -> 'v3'

Cleanup: remove unused BLI_turbulence1

A slightly modified version of BLI_turbulence1, unused for years.

Cleanup: use snake case for BLI_args API

Cleanup: remove unused BLI_argsArgv

Cleanup: use string APPEND/PREPEND

Replace 'set' with 'string(APPEND/PREPEND ...)'.
This avoids duplicating the variable name.

Cleanup: transform.h comments, use doxy sections

Cleanup: sort structs, files

Cleanup: clang-format

Cleanup: unused variable

UI: Tweaks to the Warning Icon

Warning Sign Alert Icon given a more rounded border.

Differential Revision: https://developer.blender.org/D9443

Reviewed by Pablo Vazquez

Merge branch 'blender-v2.91-release'

Fix T81915: Draw Face Sets not working with deformed sculpt mesh

The draw face sets brush uses the poly center when used in meshes to increase
its precision when working in low poly geometry. For this to work with deformed
meshes, the deformed coordinates from the PBVH should be used instead.

Reviewed By: sergey

Maniphest Tasks: T81915

Differential Revision: https://developer.blender.org/D9424

Fix memory leaks in sculpt mode trimming tools

BKE_mesh_free() seems to not free the meshes correctly, so using BKE_id_free() instead.
The looptri array was also not freed.

Reviewed By: sergey

Differential Revision: https://developer.blender.org/D9426

Fix T82400: Dyntopo detail size edit operator visual glitch

Just a missing immUnbindProgram

Reviewed By: sergey

Maniphest Tasks: T82400

Differential Revision: https://developer.blender.org/D9459

Fix Dyntopo detail size preview orientation not matching the cursor

Used the sampled cursor normal when available instead of the raycast face normal.
This makes the preview match the previous orientation of the cursor.

Reviewed By: sergey

Differential Revision: https://developer.blender.org/D9460