Blender Git Loki

Fix T80282: Playback start delayed with AV sync

If current frame is set to before start frame, with AV sync there is
delay when playback is started.

Tag scene with ID_RECALC_AUDIO_SEEK, so audio playback starts from
correct position.

Reviewed By: sergey

Differential Revision: https://developer.blender.org/D8809

Cleanup: simplify tempdir_session_create

Remove the need for a temporary allocated path.

Correct last commit (where_is_temp refactor)

Changes didn't account the case when mkdtemp failed.
Previously the copying the string wasn't needed in this case.

Cleanup: refactor where_is_temp

Functionality was hard to follow as the meaning of fullname
depended on basename being NULL or not.

- where_is_temp is now only responsible for finding the temp directory.
- Split out tempdir_session_create into it's own function
that wraps mkdtemp.
- Rename basename to tempdir, fullname to tempdir_session.

Cleanup: remove outdated comment

Should have been removed in b36a05bb7e794335e3415594c41d3986cdc815e8,
when Python was started after reading the preferences.

Preferences: use the users temp directory in background mode

This choice was made when preferences were not read in background mode,
so the temp dir needed to be initialized with something.
See bc9848f7e67c3e695403179f8bcdb78b0e5764a3.

Now preferences are always read there is no reason to ignore this
particular preference in background mode.

Anyone wanting to do background renders that ignore their preferences
can run with factory startup.

Cleanup: BKE_appdir store static values in a struct, clarify names

Avoid multiple static variables with odd names,
instead keep them all in one struct, expand their names for clarity.

Fix error in last commit printing NULL strings

While this works with GCC, printing NULL strings is undefined behavior.

BKE_appdir: log details about path lookups

These were printf's, disabled by a define that could be uncommented.

Use logging since this can be useful when investigating any issue
with paths not being found at the expected location.

Without this any problem finding app-templates, Python's installation,
icons ... etc are quite difficult to troubleshoot especially on systems
without access to system-call tracing.

To use this run:
blender --log "bke.appdir" --log-level 3

Fix color-management ignoring the data-path command line value

Initialize ImBuf (and color-management) after passing arguments
that set environment variables such as `--env-system-datapath`

This also fixes a bug where BKE_appdir logging failed since it was
called before the `--log` argument was passed.

Add asserts so this doesn't happen again.

Cleanup: clarify names in appdir

- ver -> version.
- env -> env_path.

Cleanup: BKE_appdir left paths set even when not found

Internally appdir functions would test if a path exists,
returning false if it doesn't, leaving the string set instead
of clearing it.

This is error prone as invalid paths could be used accidentally.

Since BKE_appdir_folder_id_user_notest & BKE_appdir_folder_id_version
depend on this, add a 'check_is_dir' argument so the path can be used
even when the directory can't be found.

Cleanup: Remove duplicated View2D pan polling logic

Same as 21fc4ae20692, but for view panning this time. Also had to set the poll
callbacks still in this case.

Revert part of previous commit

The change to the `poll()` callback was actually incorrect. But also
reduandant, since the function is actually already executed in the operator.

Fix compile error when compiling with WITH_INPUT_NDOF after View2D changes

Actually, fixes compile error and an incorrect poll.

Caused by 21fc4ae20692 and 3a1cf838ca09.
The poll has to perfrom the `view_zoom_poll()` logic to ensure correct context.

Fix error in previous commit...

Fix possible un-initialized variable use in UI code

Uncovered by a4aa94c41cb7. Before that, it would actually be a possible `NULL`
pointer dereference.

It would happen if a `UILayout.prop()` was placed with the `full_event` option
set to `True` (or the C equivalent) for a non keymap-item property.
Now this the `full_event` option is ignored then with a warning print.

Fix issues with calling View2D zoom operators in an `EXEC` context

Multiple related issues:
* `view_zoomdrag_exec()` required `view_zoomdrag_init()` to be called first to
set up data. Can now easily be done in the `_exec()` function as well though.
* Because of that the operators could not be called in an `EXEC_` context (e.g.
`EXEC_REGION_WIN`).
* With "Zoom to Mouse Position" enabled, zooming from a menu or script would
zoom to the mouse position. That should only happen if the operators are
called directly in the editor.

Cleanup: Remove redundant View2D operator poll check

The poll would already be executed as operator callback, this check was
redundant. Also see previous commit.

Cleanup: Remove duplicated View2D zoom polling logic

`view_zoomdrag_init()` would perform a number of sanity checks that
`view_zoom_poll()` already executed. The design of operators forsees that
(non-expensive) context sanity checks are done by the `poll()` callbacks, and
the execution callbacks can then just assume that happened. No reason to be
overly pedantic, we don't do that elsewhere either.

Note that this code is from the earliest days of an operator design. So it's
not surprising that it wasn't using the design "properly".