Blender Git Loki

Clang-Tidy: Enable bugprone-misplaced-widening-cast

Clang-Tidy: enable readability-named-parameter

Fix utterly broken code regarding GPUtextures of MovieClip in readfile.c

Treat those as pure runtime code, reset to NULL by reading code, for
now.

Think those could be handled like Image gputextures (i.e. considered
runtime cache and preserved across undo steps), but probably not
critical for now.

Move MovieClip to new undo cache management system.

Clang-Tidy: enable bugprone-too-small-loop-variable

Clang-Tidy: enable bugprone-assert-side-effect

Looks like we have no assertions with side effects.

Clang-Tidy: More fixed of redundant check before delete

For some reason got unnoticed in the original cleanup pass.

Clang-Tidy: enable bugprone-argument-comment

It was called `inverted` in the header.

Cleanup: Remove redundant logic

Fix memory leak when dragging shaderfx

Clang-Tidy: Fix readability-delete-null-pointer warnings

Also enable it in the configuration.

UI: Use sliders and [0, 1] ranges in ocean modifier

The ocean modifier has two properties that use a [0, 10] hard min and
hard max. The values act as factors though, so it makes more sense to
use sliders and a 0 to 1 range.

This commit also bumps the file subversion to avoid repeatedly applying
the change to the properties' range.

Differential Revision: https://developer.blender.org/D8186

Cleanup: Editors/Sculpt/Paint, Clang-Tidy else-after-return fixes

This addresses warnings from Clang-Tidy's `readability-else-after-return`
rule in the `source/blender/editors/sculpt_paint` module.

No functional changes.

Cleanup: Editors/Screen, Clang-Tidy else-after-return fixes

This addresses warnings from Clang-Tidy's `readability-else-after-return`
rule in the `source/blender/editors/screen` module.

No functional changes.

Cleanup: Explicit return in each `else if` block in `ed_screen_context()`

The `ed_screen_context()` function is approximately 700 lines long, and
its main structure is a huge chain of `else if` statements. Some of the
bodies did not return, but rather fell through and relied on the `return
-1;` at the bottom of the function. This means that in order to truly
understand what is going on in one of those `else if` blocks, it could
be required to scroll past all the following `else if` blocks,
double-checking that they all had an `else`, and then see what happens
below.

By adding explicit `return -1;` everywhere this happened, this is all
avoided, increasing local understandability of the code. Furthermore, it
makes the upcoming cleanup with the Clang-Tidy rule
`readability-else-after-return` a lot easier to do.

No functional changes.

Cleanup: Editors/Object, Clang-Tidy else-after-return fixes

This addresses warnings from Clang-Tidy's `readability-else-after-return`
rule in the `source/blender/editors/object` module.

No functional changes.

Cleanup: Editors/Mesh, Clang-Tidy else-after-return fixes

This addresses warnings from Clang-Tidy's `readability-else-after-return`
rule in the `source/blender/editors/mesh` module.

No functional changes.

Cleanup: Editors/Armature, Clang-Tidy else-after-return fixes

This addresses warnings from Clang-Tidy's `readability-else-after-return`
rule in the `source/blender/editors/armature` module.

No functional changes.

Cleanup: Editors/Animation, Clang-Tidy else-after-return fixes

This addresses warnings from Clang-Tidy's `readability-else-after-return`
rule in the `source/blender/editors/animation` module.

No functional changes.

Fix Pose Brush crashing after disabling connected only in FK mode

This function was returning the ik_chain before disabling the
fake_neighbors, so when the brush was used again with fake neighbors
disabled after rebuilding the PBVH and free them, they were still
enabled in the SculptSession, causing a the crash.

Reviewed By: sergey

Differential Revision: https://developer.blender.org/D8195