Blender Git Loki

Cleanup: line length in Python scripts

Cleanup: spelling in comments

Geometry Nodes: Rename node "String Substring"

This patch renames the node "String Substring" to "Slice String"
to conform to the "verb first" naming convention.
Default length is also changed to 10 to make it easier for users
to understand what the node does.

Reviewed By: HooglyBoogly

Differential Revision: https://developer.blender.org/D12931

Fix T92400: Denoise node Prefilter output is always "Fast"

Caused by an accidental renaming in {rB1c42d4930a24d639b3aa561b9a8b4bbc}

Cleanup: use underscore suffix for private data members

Cleanup: remove unused function

It doesn't have definition either.

Fix: Add missing TBB define to geometry module

Assets/UI: Improve asset library Preferences UI

* Open File Browser when pressing "Add Asset Library". This just makes sense,
since users have to select a directory for the asset library anyway.
* Move '+' icon back to the right side of the box. Then it is right under the
'x' icons for each indivdual library, which seems like the more natural
place.
* Correct tooltip for the "Add Asset Library" operator.
* Mark empty asset library name or paths field in red, to make clear that these
need to be set.

Fix: Asset using selection in instances to points node

Caused by my own incorrect cleanup when committing the patch.

GitHub: add PR template
Differential Revision: https://developer.blender.org/D12890

Geometry Nodes: Add Instances to Points Node

This node takes a geometry set with instances as input and outputs
points located on the origins of the top level of instances in the
geometry set (not nested instances). It also has position and radius
inputs to allow overriding the default, and a selection input to only
generate points for some instances.

The use case for this node is a method to use geometry proximity on
instance origins, but in a more generic way that is flexible and useful
in other situations.

Differential Revision: https://developer.blender.org/D12893

Fix: Empty geometry nodes input menu with legacy nodes enabled

Caused by a misplaced comma at the end of a line in Python.

Fix: Support swapped inputs properly in trim curve node

Previously, when the start input was greater than the end input,
the spline was resized to a single point. That is correct, but the
single point wasn't placed properly along the spline. Now, it is
placed according to the "Start" value, as if the trim started, but
couldn't continue because the "End" value was smaller.

This behavior is handled with a separate code path to keep each
simpler and avoid special cases. Any cleanup to reduce duplication
should focus on making each code path shorter separately rather
than merging them.

Also included are some changes to `lookup_control_point_position`
to support cyclic splines, though this single-point method is still
disabled on cyclic splines for consistency.

Docs: Fixes and improvements in API documentation

Fixes several notable mistakes and missing information
regarding the API documentation (*.rst).

This will allow API stub generators like bpystubgen or
fake-bpy-module to produce more accurate result.

Differential Revision: https://developer.blender.org/D12639

Fix: Cyclic single point bezier splines have multiple evaluated points

Because `segment_is_vector` didn't handle the combined cyclic and
single control point case, it returned false, that the "segment" should
have the resolution evaluated point count. To avoid checking the size in
every call, add an assert for the size and check it elsewhere.

Asset Browser: Filter options for specific ID types

Adds a filter popup to the header that allows specifiying which data-block
types to show. The menu automatically reflects all supported ID types, so it
shows a checkbox for materials, worlds and actions currently by default, and
all ID types with the "Extended Asset Browser" experimental feature enabled.

UI: Correct icons of File Browser Link/Append ID filter settings

Wasn't using the same icons as usually used for these IDs, which can be
confusing. Corrected them to be consistent with other usages of these IDs.

UI: Show ID filter settings in Link/Append File Browser as icon & checkbox

The checkboxes integrate better with the surrounding layout and are not that
attention grabbing. To my knowledge the only reason not to use checkboxes was
so the icons could be displayed. But this does it just like the Outliner filter
settings: Show the icon before the checkbox.

Also widen the popover a bit to fit longer labels (didn't fit before this patch
even).

Fix: Assert for unused field evaluator in resample curve node

Declare it at a lower scope so it doesn't go unused in evaluated mode.

Fix: Double calculation of UVs in cone primitive