Blender Git Commit Log

Git Commits -> Revision 10d775d

Revision 10d775d by Joshua Leung (master)
June 26, 2011, 14:50 (GMT)
AnimChannels Filtering Refactor - Part 4

This commit is aimed at cleaning up the filtering code by changing the
filtering idiom/pattern used. While the old code used a "check then
do" approach, the new code does a "grab then assimilate".

The main benefits are that:
* the code duplication that used to exist has now been removed, making
it easier to add new channel types for data
* a recursive "peeking" ability now means that the old problems with
data existing deep in the tree (i.e. figuring out whether a channel
should be shown based on whether it will have any descendents) should
now work much better than before.

In the process, I've found and fixed a few previously unnoticed bugs
with how some channels were constructed, so hopefully things work a
bit better now.

TODO's:
* Action-Group filtering stuff hasn't been refactored yet. This was
causing some grief in the past, so I still need to check this
carefully.
* Material Nodes support (missing in trunk) should be easy to slot in
now :)

Commit Details:

Full Hash: 10d775df3d31ce7622ebb74ed7276cff5f1ffe90
SVN Revision: 37826
Parent Commit: 5663d85
Lines Changed: +553, -891

2 Modified Paths:

/source/blender/editors/animation/anim_filter.c (+549, -889) (Diff)
/source/blender/editors/include/ED_anim_api.h (+4, -2) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021