Blender Git Commit Log

Git Commits -> Revision 1710848

Revision 1710848 by Martin Poirier (master)
January 12, 2010, 23:30 (GMT)
[#20093] Consistent Crash in properties window

Fun bug, took me the better part of the day to track down.

Happens because maximizing swaps spacedata lists between the old area and the newly created maximized area (this one being empty) while ui handlers are still hanging with references to the first area (then trying to access spacedata when handled). And then only if a maximizing operator was run before the UI realign timer event from the previous maximize was handled (fun, I told you).

After discussion with Matt on irc, we decided the best way to deal with that was to remove ui handlers that reference areas of a screen that is no longer used. That solution reflects the fact that the bug is more general that the reproducing steps would lead to believe. There's also absolutely no reason to run UI handlers on invisible areas.

Commit Details:

Full Hash: 17108481a9f934102c14bacdf0b994afba00e493
SVN Revision: 25941
Parent Commit: b39be60
Lines Changed: +27, -1

3 Modified Paths:

/source/blender/editors/screen/screen_edit.c (+7, -1) (Diff)
/source/blender/windowmanager/intern/wm_event_system.c (+19, -0) (Diff)
/source/blender/windowmanager/WM_api.h (+1, -0) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021