Blender Git Commit Log

Git Commits -> Revision 18c6314

Revision 18c6314 by Brecht Van Lommel (master)
October 6, 2021, 12:21 (GMT)
Cleanup: don't detect duplicate intersections in Embree

It's unclear why this code was added in the first place, but it seems
unnecessary, it can be restored if we find this breaks something.

The Embree docs mention that the same primitive may be hit multiple times, but
my understanding is that about e.g. curves where both the frontside and backside
may be hit. However those hits would be at different distances.

The context for this change is that we want to add an optimization where we
can immediately update throughput for transparent shadows instead of recording
intersections, and avoid duplicate would require extra work. However there is
an Embree example that does something similar without worrying about duplicate
hits either.

Commit Details:

Full Hash: 18c6314e2660820778c555143b234dff3ba35ffa
Parent Commit: 3c4537c
Lines Changed: +1, -20

1 Modified Path:

/intern/cycles/bvh/bvh_embree.cpp (+1, -20) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021