Blender Git Commit Log

Git Commits -> Revision 2c9c22d

Revision 2c9c22d by Gaia Clary (master)
March 11, 2018, 19:59 (GMT)
fix Collada: wrong usage of pointer and hidden redeclaration

* Suspicious usage of pointer:

short *type = 0; // this creates a null pointer

When this is later used for anything then blender would crash.
After following the code and check what happens i strongly believe
the author wanted to use a short and not a pointer to a short here.

* local variable where reused later in same function
While this did no harm, i still felt it was better to use a different
name here to make things more separated:

- moved variable declaraiotns into loop (for int a=0; ...)
- renamed uv_images to uv_image_set
- renamed index variable from i to j in inner loop that
reused same index name from outer loop

Commit Details:

Full Hash: 2c9c22df26dfdcf03bb308fdf35294ed79c2d0e5
Parent Commit: 49a7cd1
Lines Changed: +14, -14

4 Modified Paths:

/source/blender/collada/DocumentImporter.cpp (+5, -5) (Diff)
/source/blender/collada/GeometryExporter.cpp (+2, -2) (Diff)
/source/blender/collada/ImageExporter.cpp (+2, -2) (Diff)
/source/blender/collada/MeshImporter.cpp (+5, -5) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021