Blender Git Commit Log

Git Commits -> Revision 3e7ad0e

Revision 3e7ad0e by Campbell Barton (master)
December 12, 2011, 18:06 (GMT)
fix [#29537] file/save crashes when target path isnt found

bug was that uiPupMenuSaveOver(...) could run the WM API call function which freed the operator, within the low level invoke function which kept using the freed memory.

Changed uiPupMenuSaveOver(...) to only show a popup so the caller needs to check if the file exists and should be immediately written (which was done everywhere except for blend saving anyway).

* added note that operators invoke/exec funcs cant call WM_operator_call(...) on themselves, ends up using freed memory.
* added BLI_is_file(path), checks the file exists and isnt a directory.

Commit Details:

Full Hash: 3e7ad0e2714009509004669d8da8ea8c71fa0d04
SVN Revision: 42583
Parent Commit: cd0608a
Lines Changed: +28, -22

6 Modified Paths:

/source/blender/blenlib/BLI_fileops.h (+1, -0) (Diff)
/source/blender/blenlib/intern/storage.c (+6, -0) (Diff)
/source/blender/editors/interface/interface_regions.c (+6, -14) (Diff)
/source/blender/editors/space_file/file_ops.c (+3, -3) (Diff)
/source/blender/windowmanager/intern/wm_event_system.c (+3, -1) (Diff)
/source/blender/windowmanager/intern/wm_operators.c (+9, -4) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021