Blender Git Commit Log

Git Commits -> Revision 3e9823a

Revision 3e9823a by Sybren A. Stüvel (temp-T82156-parenting-and-constraints)
November 2, 2020, 10:16 (GMT)
Cleanup: Sanitise return value of `ED_object_parent_set()`

Return `false` from `ED_object_parent_set()` when parent and child are
the same object. This would break the parenting operator, as returning
`false` stops its loop over all selected objects. This tight coupling
caused T82312.

The loop now has its own check for this, so that it properly continues,
and the implementation of `ED_object_parent_set()` is decoupled from its
surrounding code.

No functional changes.

Commit Details:

Full Hash: 3e9823ac4afa42f7f9e2d89e5b29f7d74d6d0359
Parent Commit: b801369
Lines Changed: +14, -1

2 Modified Paths:

/source/blender/editors/include/ED_object.h (+1, -0) (Diff)
/source/blender/editors/object/object_relations.c (+13, -1) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021