Blender Git Commit Log
Git Commits -> Revision 6601a89
Revision 6601a89 by Brecht Van Lommel (master) December 13, 2018, 18:25 (GMT) |
Fix T58549, T56741: HSV color picker issues with Filmic view transform. In 2d655d3 the color picker was changed to use display space HSV values. This works ok for a simple sRGB EOTF, but fails with view transforms like Filmic where display space V 1.0 maps to RGB 16.292. Instead we now use the color_picking role from the OCIO config when converting from RGB to HSV in the color picker. This role is set to sRGB in the default OCIO config. This color space fits the following requirements: * It is approximately perceptually linear, so that the HSV numbers and the HSV cube/circle have an intuitive distribution. * It has the same gamut as the scene linear color space. * Color picking values 0..1 map to scene linear values in the 0..1 range, so that picked albedo values are energy conserving. |
Commit Details:
Full Hash: 6601a89650f92454aa57bc01bedebd4086f6d98d
Parent Commit: 33993c0
Lines Changed: +199, -175
9 Modified Paths:
/release/datafiles/colormanagement/config.ocio (+1, -1) (Diff)
/source/blender/editors/interface/interface.c (+4, -17) (Diff)
/source/blender/editors/interface/interface_draw.c (+1, -4) (Diff)
/source/blender/editors/interface/interface_handlers.c (+10, -36) (Diff)
/source/blender/editors/interface/interface_intern.h (+6, -3) (Diff)
/source/blender/editors/interface/interface_region_color_picker.c (+73, -61) (Diff)
/source/blender/editors/interface/interface_widgets.c (+36, -52) (Diff)
/source/blender/imbuf/IMB_colormanagement.h (+3, -0) (Diff)
/source/blender/imbuf/intern/colormanagement.c (+65, -1) (Diff)
/source/blender/editors/interface/interface.c (+4, -17) (Diff)
/source/blender/editors/interface/interface_draw.c (+1, -4) (Diff)
/source/blender/editors/interface/interface_handlers.c (+10, -36) (Diff)
/source/blender/editors/interface/interface_intern.h (+6, -3) (Diff)
/source/blender/editors/interface/interface_region_color_picker.c (+73, -61) (Diff)
/source/blender/editors/interface/interface_widgets.c (+36, -52) (Diff)
/source/blender/imbuf/IMB_colormanagement.h (+3, -0) (Diff)
/source/blender/imbuf/intern/colormanagement.c (+65, -1) (Diff)