Blender Git Commit Log
Git Commits -> Revision 6a392e8
Revision 6a392e8 by Joshua Leung (master) July 24, 2011, 04:34 (GMT) |
== RNA Property Updates get called by Animation System now == This fixes bug #26764 and several others like it, where modifier properties (and others, but most visibly modifiers) would not do anything when animated or driven, as modifier properties require the RNA update calls to tag the modifiers to get recalculated. While just adding a call to RNA_property_update() could have gotten this working (as per the Campbell's patch attached in the report, and also my own attempt #25881). However, on production rigs, the performance cost of this is untenatable (on my own tests, without these updates, I was getting ~5fps on such a rig, but only 0.9fps or possibly even worse with the updates added). Hence, this commit adds a property-update caching system to the RNA level, which aims to reduce to the number of times that the update functions end up needing to get called. While this is much faster than without the caching, I also added an optimisation for pose bones (which are numerous in production rigs) so that their property updates are skipped, since they are useless to the animsys (they only tag the depsgraph for updating). This gets things moving at a more acceptable framerate. |
Commit Details:
Full Hash: 6a392e8cb505b753a0bac24e42778306007c45b8
SVN Revision: 38649
Parent Commit: c22f26d
Lines Changed: +174, -35
15 Modified Paths:
/source/blender/blenkernel/BKE_animsys.h (+2, -2) (Diff)
/source/blender/blenkernel/intern/action.c (+1, -1) (Diff)
/source/blender/blenkernel/intern/anim.c (+2, -2) (Diff)
/source/blender/blenkernel/intern/anim_sys.c (+28, -6) (Diff)
/source/blender/blenkernel/intern/blender.c (+5, -0) (Diff)
/source/blender/blenkernel/intern/key.c (+1, -1) (Diff)
/source/blender/blenkernel/intern/object.c (+2, -2) (Diff)
/source/blender/blenkernel/intern/particle_system.c (+4, -4) (Diff)
/source/blender/blenkernel/intern/scene.c (+5, -5) (Diff)
/source/blender/blenkernel/intern/sequencer.c (+2, -2) (Diff)
/source/blender/editors/space_view3d/drawanimviz.c (+4, -4) (Diff)
/source/blender/editors/space_view3d/drawarmature.c (+4, -4) (Diff)
/source/blender/makesrna/intern/rna_access.c (+109, -1) (Diff)
/source/blender/makesrna/RNA_access.h (+4, -0) (Diff)
/source/blender/render/intern/source/pipeline.c (+1, -1) (Diff)
/source/blender/blenkernel/intern/action.c (+1, -1) (Diff)
/source/blender/blenkernel/intern/anim.c (+2, -2) (Diff)
/source/blender/blenkernel/intern/anim_sys.c (+28, -6) (Diff)
/source/blender/blenkernel/intern/blender.c (+5, -0) (Diff)
/source/blender/blenkernel/intern/key.c (+1, -1) (Diff)
/source/blender/blenkernel/intern/object.c (+2, -2) (Diff)
/source/blender/blenkernel/intern/particle_system.c (+4, -4) (Diff)
/source/blender/blenkernel/intern/scene.c (+5, -5) (Diff)
/source/blender/blenkernel/intern/sequencer.c (+2, -2) (Diff)
/source/blender/editors/space_view3d/drawanimviz.c (+4, -4) (Diff)
/source/blender/editors/space_view3d/drawarmature.c (+4, -4) (Diff)
/source/blender/makesrna/intern/rna_access.c (+109, -1) (Diff)
/source/blender/makesrna/RNA_access.h (+4, -0) (Diff)
/source/blender/render/intern/source/pipeline.c (+1, -1) (Diff)