Blender Git Commit Log

Git Commits -> Revision 78b9a8c

Revision 78b9a8c by Gaia Clary (master)
September 29, 2021, 11:09 (GMT)
Add an option to silence bpy.ops.anim.keyframe_delete_v3d when used in Addons

The issues:

1.) When we want to remove keyframes from a range of frames in an
action,
then we can use bpy.ops.anim.keyframe_delete_v3d to remove the keys
frame by frame. However, whenever the operator hits a frame with no
keyframes, then it generates an error. While when it hits a frame
with keyframes, then it reports the numbner of removed keys.

This creates a lot of unnecessary noise in the Blender console.

2.) Furthermore a related issue is that WM_event_add_notifier() is
called also when no frames where removed. This seems to significantly
slow down the removal of keyframes in a range of frames at least
when i use vscode for debugging.

A proposal for improvement:
This patch adds an attribute 'confirm_success' which controls
if the operator reports back what it did (or did not) while
executing. Silent mode would then be called like this:

bpy.ops.anim.keyframe_delete_v3d(confirm_success=False)

Note: confirm_success is True by default so this patchj does not
change the behavior of Blender, it only gives the option to scripts.

3.) Personal note:
I have chosen the attribute name to be equal as it is used
in other related operators. However i rather would rename the
attribute to "verbose" (preferred) or "with_confirm". But i let this
to be decided by the reviewers. Thanks for your time to review!

Reviewed By: campbellbarton

Differential Revision: https://developer.blender.org/D12629

Commit Details:

Full Hash: 78b9a8c7b993991c22ac2bd1ffbfaf1d896e4431
Parent Commit: 6351c73
Lines Changed: +17, -13

By: Miika HämäläinenLast update: Nov-07-2014 14:18 MiikaHweb | 2003-2021