Blender Git Commit Log

Git Commits -> Revision 7ac4e87

Revision 7ac4e87 by Philipp Oeser (master)
October 22, 2021, 17:23 (GMT)
Fix panel pinning showing for instanced panels (e.g. FCurve modifiers)

This was reported for FCurve modifiers, but was also true (in theory) for
other instanced panels (regular modifiers, spreadsheet filters, ...),
these would not show pinning for other reasons (no caterories).

So in the case of the Graph Editor the follwing happens:

`graph_buttons_register` only registers `GRAPH_PT_modifiers`, the panel
itself has no header (PANEL_TYPE_NO_HEADER), further panels for
individual modifiers are added dynamically in `graph_panel_modifiers`.
So when pinning a particular modifier, we would pin e.g. `GRAPH_PT_noise`
(not `GRAPH_PT_modifiers`).
ED_region_panels_layout_ex would only collect panels known to
`graph_buttons_register` (so is not aware of the specific panels of
modifiers). So while I think it should be possible to pin
`GRAPH_PT_modifiers` on top of an individual modifier's panel this would
result in all modifiers being shown in other categories [which would also
be weird]. Panel header layout was also not correct (drawing the pin
icon over the modifier delete icon).

So to resolve this, just dont use pinning for these type of panels.

part of T92293.

Maniphest Tasks: T92293

Differential Revision:

Commit Details:

Full Hash: 7ac4e874db5a176429da2cf869b0552a24ef0b3e
Parent Commit: cca811d
Lines Changed: +10, -1

By: Miika HämäläinenLast update: Nov-07-2014 14:18 MiikaHweb | 2003-2021