Blender Git Commit Log

Git Commits -> Revision 7e02d33

Revision 7e02d33 by Mike Erwin (master)
August 19, 2016, 04:52 (GMT)
OpenGL: don't poll for errors, rely on KHR_debug

Errors are caught & reported by our GL debug callback. This gives us way more useful information than sporadic calls to glGetError.

I removed almost all use of glGetError, including our own GPU_ASSERT_NO_GL_ERRORS and GPU_CHECK_ERRORS_AROUND macros.

Still used in rna_Image_gl_load because it passes unvalidated input to OpenGL functions.

Still used in gpu_state_print_fl_ex as an exception handling hack -- will rewrite this soon.

The optimism embodied by this commit will not prevent OpenGL errors. We need to analyze what would cause GL to fail at certain points and proactively intercept these failures. Or guarantee they can't happen.

Commit Details:

Full Hash: 7e02d335c0ce9e88fb08d1e499b6563980d0d8e9
Parent Commit: d8f036e
Lines Changed: +47, -260

12 Modified Paths:

/source/blender/editors/interface/interface_icons.c (+0, -5) (Diff)
/source/blender/gpu/GPU_debug.h (+0, -15) (Diff)
/source/blender/gpu/GPU_framebuffer.h (+1, -1) (Diff)
/source/blender/gpu/intern/gpu_compositing.c (+15, -19) (Diff)
/source/blender/gpu/intern/gpu_debug.c (+2, -120) (Diff)
/source/blender/gpu/intern/gpu_framebuffer.c (+10, -30) (Diff)
/source/blender/gpu/intern/gpu_material.c (+4, -4) (Diff)
/source/blender/gpu/intern/gpu_shader.c (+2, -22) (Diff)
/source/blender/gpu/intern/gpu_texture.c (+7, -30) (Diff)
/source/blender/makesrna/intern/rna_image_api.c (+2, -0) (Diff)
/source/blender/windowmanager/intern/wm_draw.c (+4, -10) (Diff)
/source/blender/windowmanager/intern/wm_event_system.c (+0, -4) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021