Blender Git Commit Log

Git Commits -> Revision b97cd0e

Revision b97cd0e by Alexander Gavrilov (master)
December 4, 2018, 11:08 (GMT)
Depsgraph: execute all COPY_ON_WRITE nodes first as a separate stage.

COW nodes in the graph are mostly connected via a relation type
that doesn't propagate the update flags. Unfortunately, due to
the scheduling implementation that means the relations don't
actually guarantee execution order for indirect dependencies.
Relations also don't guarantee order in case of cycles.

As mentioned in IRC, the simplest way to fix possible problems
is to execute all COW nodes as a separate execution stage. This
seems to fix crashes with Data Transfer modifier in a cycle.

Staging works by simply delaying actual scheduling of tasks for
non-COW nodes until the second run of schedule_graph.

Reviewers: sergey

Differential Revision: https://developer.blender.org/D4027

Commit Details:

Full Hash: b97cd0e6908b133514232c57509861ca06eca91e
Parent Commit: 01581d4
Lines Changed: +21, -0

2 Modified Paths:

/source/blender/depsgraph/intern/depsgraph.cc (+3, -0) (Diff)
/source/blender/depsgraph/intern/eval/deg_eval.cc (+18, -0) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021