Blender Git Commit Log

Git Commits -> Revision d9697bc

Revision d9697bc by Antonis Ryakiotakis (master)
January 5, 2014, 02:58 (GMT)
Fix T38024 crash when rebuilding sculpt mode buffers.

Main issue here is that glBuf* calls were invoked from threads different than
main thread. This caused a crash (since those do not have a GL context active).

Fix here is twofold:
* add an ID buffer in buffer pool that handles pbvh buffers and is freed
from main thread when gpu_buffer_pool_free_unused is called.

* do not create glbuffers in derivedmesh creation routine, rather tag nodes
for update and create those in the draw function
(guaranteed to be called from main thread)

Reviewed By: brecht

Differential Revision: https://developer.blender.org/D169

Commit Details:

Full Hash: d9697bc1455dc556fd233aae9d45b523af62669b
Parent Commit: 0074eac
Lines Changed: +57, -21

3 Modified Paths:

/source/blender/blenkernel/intern/pbvh.c (+1, -9) (Diff)
/source/blender/blenkernel/intern/pbvh_bmesh.c (+3, -6) (Diff)
/source/blender/gpu/intern/gpu_buffers.c (+53, -6) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021