Blender Git Commit Log

Git Commits -> Revision f7857ec

Revision f7857ec by Joshua Leung (master)
January 3, 2011, 11:58 (GMT)
2.4x <-> 2.5 Regression Fixes: Shapekey Problems

This commit partially fixes the problems with Shapekeys from older
files, as seen from the Regression suite (relative.blend and
dolphin.blend in particular).

In older files, keyblock->slidermax was never truly set to 1.0 even
though the UI may have shown such a value (which was bizzarely being
sourced from somewhere else). Hence, after loading the files in 2.5,
the shapekeys wouldn't animate, as the value would get clamped between
0 and 0.

To fix this, I've added a version patch which corrects these
situations in old files, and I've adjusted the slider-RNA code so that
it is not possible to set up such clamping anymore.

TODO:
The fixes detailed here only make it possible for these files to work
again in 2.5. However, I haven't been able to find a way to get the
files to actually work in 2.5 without manually changing the active
shapekey (per object) after loading the files with these patches
applied. Possibly it's just some depsgraph magic needed, unless
there's still some other evil voodoo in the shapekey code

Commit Details:

Full Hash: f7857ec81b960b361c81d6619dfaf28f4e8d7ae0
SVN Revision: 34032
Parent Commit: e7ed8a3
Lines Changed: +58, -1

2 Modified Paths:

/source/blender/blenloader/intern/readfile.c (+15, -1) (Diff)
/source/blender/makesrna/intern/rna_key.c (+43, -0) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021