Blender Git Loki

Fixing USDImporterContext forward declaration.

Cleanup: refactor where_is_temp

Functionality was hard to follow as the meaning of fullname
depended on basename being NULL or not.

- where_is_temp is now only responsible for finding the temp directory.
- Split out tempdir_session_create into it's own function
that wraps mkdtemp.
- Rename basename to tempdir, fullname to tempdir_session.

Cleanup: remove outdated comment

Should have been removed in b36a05bb7e794335e3415594c41d3986cdc815e8,
when Python was started after reading the preferences.

Preferences: use the users temp directory in background mode

This choice was made when preferences were not read in background mode,
so the temp dir needed to be initialized with something.
See bc9848f7e67c3e695403179f8bcdb78b0e5764a3.

Now preferences are always read there is no reason to ignore this
particular preference in background mode.

Anyone wanting to do background renders that ignore their preferences
can run with factory startup.

Cleanup: BKE_appdir store static values in a struct, clarify names

Avoid multiple static variables with odd names,
instead keep them all in one struct, expand their names for clarity.

Fix error in last commit printing NULL strings

While this works with GCC, printing NULL strings is undefined behavior.

BKE_appdir: log details about path lookups

These were printf's, disabled by a define that could be uncommented.

Use logging since this can be useful when investigating any issue
with paths not being found at the expected location.

Without this any problem finding app-templates, Python's installation,
icons ... etc are quite difficult to troubleshoot especially on systems
without access to system-call tracing.

To use this run:
blender --log "bke.appdir" --log-level 3

Fix color-management ignoring the data-path command line value

Initialize ImBuf (and color-management) after passing arguments
that set environment variables such as `--env-system-datapath`

This also fixes a bug where BKE_appdir logging failed since it was
called before the `--log` argument was passed.

Add asserts so this doesn't happen again.

Cleanup: clarify names in appdir

- ver -> version.
- env -> env_path.

Merge branch 'master' of git://git.blender.org/blender

uncommit

commit patch

LineArt: Fix compiler warnings for windows.

Merge remote-tracking branch 'origin/master' into lanpr-under-gp

# Conflicts:
# source/blender/makesrna/intern/rna_gpencil_modifier.c

Alembic import: add an option to force the addition of a modifier on
every object

This way we can read the full file from Cycles.

add procedurals to update stats

Cleanup: BKE_appdir left paths set even when not found

Internally appdir functions would test if a path exists,
returning false if it doesn't, leaving the string set instead
of clearing it.

This is error prone as invalid paths could be used accidentally.

Since BKE_appdir_folder_id_user_notest & BKE_appdir_folder_id_version
depend on this, add a 'check_is_dir' argument so the path can be used
even when the directory can't be found.

Invoking copy_zup_from_yup() function.

Coding convention fixes.

Cleanup: Remove duplicated View2D pan polling logic

Same as 21fc4ae20692, but for view panning this time. Also had to set the poll
callbacks still in this case.