Blender Git Loki

Revert part of previous commit

The change to the `poll()` callback was actually incorrect. But also
reduandant, since the function is actually already executed in the operator.

Fix compile error when compiling with WITH_INPUT_NDOF after View2D changes

Actually, fixes compile error and an incorrect poll.

Caused by 21fc4ae20692 and 3a1cf838ca09.
The poll has to perfrom the `view_zoom_poll()` logic to ensure correct context.

Removed extraneous printf() call.

Fix error in previous commit...

Fix possible un-initialized variable use in UI code

Uncovered by a4aa94c41cb7. Before that, it would actually be a possible `NULL`
pointer dereference.

It would happen if a `UILayout.prop()` was placed with the `full_event` option
set to `True` (or the C equivalent) for a non keymap-item property.
Now this the `full_event` option is ignored then with a warning print.

Fix issues with calling View2D zoom operators in an `EXEC` context

Multiple related issues:
* `view_zoomdrag_exec()` required `view_zoomdrag_init()` to be called first to
set up data. Can now easily be done in the `_exec()` function as well though.
* Because of that the operators could not be called in an `EXEC_` context (e.g.
`EXEC_REGION_WIN`).
* With "Zoom to Mouse Position" enabled, zooming from a menu or script would
zoom to the mouse position. That should only happen if the operators are
called directly in the editor.

Cleanup: Remove redundant View2D operator poll check

The poll would already be executed as operator callback, this check was
redundant. Also see previous commit.

Cleanup: Remove duplicated View2D zoom polling logic

`view_zoomdrag_init()` would perform a number of sanity checks that
`view_zoom_poll()` already executed. The design of operators forsees that
(non-expensive) context sanity checks are done by the `poll()` callbacks, and
the execution callbacks can then just assume that happened. No reason to be
overly pedantic, we don't do that elsewhere either.

Note that this code is from the earliest days of an operator design. So it's
not surprising that it wasn't using the design "properly".

Property Search: Set panel expansion when tab changes

This commit makes the panel expansion set based on the search results
when the active tab in the properties editor changes. The multi-tab
search patch (D8859) actually doesn't handle this because it uses a
different code path.

This feature uncovered a subtle but fairly significant issue with the
implementation of property search (More details in T81113). Basically,
the search needed multiple redraws to properly display the expansion of
panels based on the search results. Because there is no animation of
panel expansion when switching tabs, the problem was exposed only now.

With this commit, hiding of "search only" buttons and panel size
calculation happens in a single final step of the panel layout pass.
The "search only" layout root flag is removed. Instead every button
inside a panel header is in a single "uiButtonGroup" marked with a
specific "in header" flag, an idea which could be generalized in the
future.

Differential Revision: https://developer.blender.org/D9006

Cleanup: use BLI_path_join in appdir.c to simplify logic

Change `test_path` function so:

- Joining paths calls a function instead of being performed inline.
- Optional NULL paths must always be ordered last (easier to follow).

Other minor changes:

- Remove FIXME comment is it's handled properly by BLI_path_join.
- The wrong size was being used copying into `targetpath`.

Cleanup: Remove/replace C standard library assert() and header usages

We have our own assert implementation, `BLI_assert()` that is prefered over the
C standard library one. Its output is more consistent across compilers and
makes termination on assert failure optional (through `WITH_ASSERT_ABORT`).

In many places we'd include the C library header without ever accessing it.

Cleanup: Remove dead code in panel logic

The region types checked here were removed from the editors in 9e2abbc9ba5d and
eb7485389b8a. So the if-conditions would never be true.

Fix error in recent change "run UserDef versioning from readfile.c"

Missed moving the defines in CMake for e255040c7797
causing cycles not to be enabled.

Cleanup: use doxy sections for appdir.c

Keep related functionality grouped.

Cleanup: comments for appdir

Use doxy syntax & minor improvements.

Merge branch 'master' into greasepencil-object

Merge branch 'master' into greasepencil-edit-curve

Conflicts:
source/blender/blenloader/intern/versioning_290.c

GPencil: Fix unreported wrong name for RNA setter

The Vertex Group setter function name was wrong for Tint modifier.

Cleanup: move temp directory environment checks into a loop

Minimizes ifdef'd code for WIN32.

Fix invalid temp-dir for image-project on unsaved files

The preferences tempdir being used instead of bpy.app.tempdir.