Blender Git Loki

Fix T60267: Assert manipulating a collection

Cleanup: move comments above definitions

For clang-format not to wrap definitions.

clang-format: Add FixNamespaceComments

Generally useful hint.

clang-format: disable formatting via comments where possible

Merge branch 'master' into temp-clang-format

Cleanup: compiler warnings

Merge branch 'greasepencil-object' into greasepencil-experimental

anim bind rotation fix (again)

NLA: ignore time range when evaluating a raw action.

When editing an action without a strip, or tweaking a strip without
time mapping enabled or supported, the extents of the virtual strip
can't be controlled and are purely derived from keys in the action.

Thus, cutting off evaluation of the action at these arbitrary points
gets in the way of observing the natural extrapolation of the F-Curves
and thus appears to be a mis-feature.

With this change non-mapped actions are evaluated with infinite
range, exactly like they are handled without NLA, unless extend
mode is set to Nothing.

GP: Cleanup missing brackets

Viewport: Stereoscopy drawing is back

The viewport stereoscopy support helpers are finally ported to 2.80.

We now can scale the camera and the "stereo cameras" will scale
in the viewport as well (unlike 2.7x).

At the moment I disabled the drawing of the camera frame when
stereo is selected and you are looking through the camera.

It is to be fixed later, but for now it draws the border wrong.
In 2.79 this was not a problem because the camera frame was drawn
afterwards as a hack.

Viewport > Stereoscopy:
* Cameras
* Convergence plane
* Convergence plane alpha
* Stereoscopy volume
* Stereoscopy volume alpha

BKE_camera_multiview_model_matrix: Add _scaled version

For drawing it is useful to have the non-normalized version of the matrix.
So we can scale up the cameras drawing accordingly.

Drawing API: shgroup_instance and shgroup_instance_alpha clarification

shgroup_instance_alpha was getting a color[4] but would only use the
alpha defined upon creation of the shading group.

This was very limiting since it wouldn't allow for different instances
to have different alpha values.

Patch made with Cl�ment Foucault (he made the code of it, while I fixed
all the parts of the code that were relying on shgroup_instance_alpha.

Fix T60328: Stereoscopy Convergence Plane broken

The original issue is that we were changing the camera shiftx
temporarily for the stereoscopic calculation. However we are using the
evaluated object when calculating the projection matrix.

Note: Camera framing drawing for stereo still seems to be broken.
But the viewport itself is now correct.

Fix T60401: Shape key's from pointer being set to evaluated CoW ID.

Not sure exactly why this happened for 'apply as shape' and not in other
cases (did not took time to fully trace what happens there). But in any
case, `BKE_key_evaluate_object_ex()` can be called from a fair amount of
places, including during depsgraph evaluation, so setting back key's
owner here is plain wrong in CoW era.

Fix T60402: Increased data.users value, when running: C.active_object.to_mesh(C.depsgraph, True) - on curve.

More like a band-aid than anything else really, that code is horribly
weak and need to be fully re-written at some point (putting all those
temp data-blocks fully outside of bmain...). But for now should do.

=Fix unused func warning in GP code...

Fix syntax error breaking compile in GP code.

Seriously? Build your code before committing!!!

Revert "Fix T57371: Generative modifiers in editmode display vertex group weights ..."

This reverts commit 6dbfd7f6d6bc9bea9556861eba682a3126b5ed40.

Fix T57371: Generative modifiers in editmode display vertex group weights

In a better way...

6dbfd7f6d6bc would make the final vertex weights always calculated in
edit mode. Now it's only if the option is enabled.