Blender Git Loki

Cleanup/followup to previous commit: get rid of dashed-specific helpers.

Those are no more needed.

Reworked version of dashed line shader.

Using geometry shader allows us to get rid of the 'line origin' extra
vertex attribute, which means dashed shader no longer requires fiddling
with those vertex attributes definition, and, most importantly, does not
require anymore special drawing code!

As you can see, this makes code much simpler, and much less verbose,
especially in complex cases.

In addition, changed how dashes are handled, to have two 'modes', a
simple one with single color (using default "color" uniform name), and a
more advanced one allowing more complex and multi-color patterns.

Note that since GLSL 1.2 does not support geometry shaders, a hack was
added for now (which gives solid lines, but at least does not make
Blender crash).

Merge branch 'blender2.8' into greasepencil-object

Odd use of BLI_strncpy (just use strcpy)

Merge branch '28' into workspaces

WITH_CLAY_ENGINE: Should be used for CLAY only, not drawmanager

Draw Manager: Fix copy-paste harmless comment "typo"

Blender 2.8: Update arc config

Check we've got GLEW version 2 when building with core profile

There was a bug in older GLEW version which kept glGenVertexArrays as NULL
when 3.2 core context is requested [1].

Didn't find a way to check GLEW version from CMake, it seems the version
is not really exposed to the header.

[1] https://sourceforge.net/p/glew/bugs/124/

fix typo in WITH_SYSTEM_GFLOG in CMakeLists.txt

Reimplement curve smoothing in a clear way without premature optimizations.

The original code tries too hard to avoid allocating more memory, which
reduces clarity and is not necessary here as there aren't that many
f-curve keyframes in any case. Rewriting the code with a generic solver
somehow fixed the behavior of the curve in the totally unclamped case,
which suggests that there was a bug hidden in the optimizations.

In addition, the new solver allows treating the case when an Auto curve
segment ends at a Vector handle specially as a zero acceleration boundary
condition.

Getting rid of setlinestyle: sample line in Image space.

Getting rid of setlinestyle: UV editor drawing.

Getting rid of setlinestyle: remove gpencil's debug-only dashed line drawing.

No need to add extra complexity of conditional dashing here for now!

Getting rid of setlinestyle: ed_util's pos-to-mouse dashed line.

Getting rid of setlinestyle: GPencil eraser.

Note the ugly hack on number of segments for outline dashed circle, to
get an OK-ish rendering of dashes...

Getting rid of setlinestyle: add imm_draw_circle_wire_dashed() util.

Needed a bit of twisting in generic private func behind the imm_draw_circle
helpers, but think it's fine.

Note that this demonstrate yet another downside of new dashed shader
compared to olde line style: not only does it needs more complex setup,
and can only work with PRIM_LINES type of primitives, but it also
behaves totally wrong with chained short segments!

We really need to find a better way to do this effect at some point. :(

Cleanup: comment blocks

Merge branch 'master' into blender2.8

Cleanup: comment blocks