Blender Git Loki

Cycles: Fix samples scheduling on retina screens

Text Editor: don't force other views to follow the cursor

While the existing behavior worked as intended,
it wasn't possible to have two views on the same file at different
locations.

Since there isn't much use in having two views open at the same location
allow one view to be at a different scroll location.

UI edit-source and selecting a text data block now need explicit calls
to scroll to the cursor location.

Resolves T87284

Fix T87291: assert on exit with preview render

Don't keep around persistent data in this case.

Cleanup: renaming, comments and removing unused code in render pipeline

Fix T85974: Edit-mode undo/redo causes assertion

Without legacy-undo, loading memfile undo only cleared edit-mode data
for mesh and armature object types.
This causes an assertion when loading edit-mode undo steps afterwards
for other object types as the existence of this data made entering
object mode fail.

Resolve this by freeing all objects types undo data from ED_editors_exit

Object: add ED_object_editmode_free_ex utility function

Cleanup: rename variable (using underscore separator)

Prepare for adding another variable that
reads poorly without a separator.

Revert "Fix entering edit-mode when object mode and edit-data don't match"

Before this change, object-data could only have
one of the objects referencing it in edit-mode.

Reverting since multiple meshes in edit-mode (for the same object data)
isn't thread-safe as the evaluated edit-meshes are created in the
original edit-mesh, causing a crash updating the depsgraph
for linked duplicates, see: T86767.

While we could support this case, it's a bigger project without
significant benefits, so reinstate the limitation of only
allowing a single object to be in edit-mode for each object data.

This adds back the error from T85974 which caused an assertion
but didn't crash in release builds.

This reverts commit 2b60d7d09c51716e8d98834061c1a61ed6b96cf5.

Cleanup: spelling

PyAPI: ImBuf.copy now copies the underlying imbuf

Without this, copy wasn't useful.

LibOverride: Fix several issues with resync code.

This commit essentially touches to post-processing of collections and
objects after resync itself has been done, to ensure their proper
instantiation in the scene:

- Remove a lot of the process in resync case (resynced data are assumed
to be already instantiated in the scene, unlike override creation
case).

- For auto-resync, only do post-processing once after all overrides
have been resynced (doing it after each individual resynced was
causing a lot of instantiation glitches, with a lot of unwanted
extra objects and collections being added to the master collection).

It also deals in a much more reliable way with detection of objects
missing from the scene, by using the new `BKE_scene_objects_as_gset`
utils.

As a bonus this makes auto-resync process slightly faster (only by a few
percents, but that's always good to get).

Outliner Override: Tweak to order of error messages.

Cleanup: Typos in comments.

BKE_collection: Add a util returning a gset with all objects in given scene's collections.

This is internaly using the code of `BKE_scene_objects_iterator` and
steals its gset. More efficient than using that iterator directly to
rebuild another GSet...

Minor cleanup to `scene_collection_array`.

Use array allocation, and remove useless check.

Outliner: regroup more type of entries under a single icon.

In folded view, some type of data are listed as one icon per item,
others are 'compacted' as a single icon with a counter.

This commit adds bones (edit, normal and pose ones), pose groups and
vertex groups as 'compacted' ones in folded view.

Part of D10855.

LibOverride: Add a dedicated view in the Outliner.

This is a minimal, information-only view currently, listing by default
all the override data-blocks, with their user-edited override
properties.

System-generated overrides (like the overrides of pointers to other
override data-blocks) can be shown through a filter option.

Finally, potential info or warning messages from (auto-)resync propcess
are also shown, as an icon + tooltip next to the affected items.

Part of D10855.

LibOverride: Add a new 'leftover' flag to ID.

This flag is set for liboverride IDs that are detected as no longer
needed by resync process, while having been user-edited, so
auto-handling code cannot silently delete them.

Exposing those to users will be part of the new incoming Override
Outliner view.

Part of D10855.

Cleanup: modernize-use-equals-default

This was missing from rB19dfb6ea1f6745c0dbc2ce21839c30184b553878.

Cleanup: enable modernize-use-equals-default check

This removes a lot of unnecessary code that is generated by
the compiler automatically.

In very few cases, a defaulted destructor in a .cc file is
still necessary, because of forward declarations in the header.

I removed some defaulted virtual destructors, because they are not
necessary, when the parent class has a virtual destructor already.

Defaulted constructors are only necessary when there is another
constructor, but the class should still be default constructible.

Differential Revision: https://developer.blender.org/D10911