Blender Git Loki

Version bump: Blender v2.91.2-release

Due to issues in the MS store we are only able to solve it by bumping
the version to 2.91.2. This will mean that there will not be an official
2.91.1 release.

Version: Blender v2.91.1 release

WindowsStore: Fix Search Bar Icon

During tests the search bar icon was not show. The reason is that the
logo in the manifest pointed to an icon that was removed.

Fix Increment Snapping Without Constraints in Non-Axis-Aligned Views

The incremental snap was always operating in the local space, which in most
cases is the VIEW type orientation.

Use only local space when the operation is affected by constraint.

Differential Revision: https://developer.blender.org/D10052

Fix T84453: Crash bezier curves transfrom

The pointer allocated to the `TransData` was being incorrectly incremented,
causing misalignment and consequently `heap-buffer-overflow`.

Because of this, `TD_NOTCONNECTED` was being set in a strange way that did
not correspond to other types of `TransData`.

The solution is to not increment the `TransData` pointer and set
`TD_NOTCONNECTED` only for "unconnected" segments.

The code was also a bit deduplicated.

Fix file-handle leak when parsing xdg user directories

Fix BKE_blender_atexit_unregister error removing from linked list

This is an old bug exposed by having multiple atexit calls since
c65c4149c9be8a1811eb389f657216fab071dfc5.

Fix T82952: Crash changing mesh data block and switching scenes

Regression in 33ac3582bbd5551bdfbc7ef8856640b5e61888f8.

Fix T79779: Pick shortest UV face-path ignores sticky setting

Fix T83372: Point.select can be True when unselected

Fix T84426: Limit dissolve ignores selection with custom normals

Regression in 9969c2dd165c7d8ffe607a5a050a80aa59ac50be.

Add note that custom normal calculation functions write into to tags.

Fix T82960: Inaccurate selection on collapsed outliner rows

After rB15083d9e1 the outliner tree is not rebuilt after expanding or
collapsing rows. Because the tree is no longer rebuilt the positions
and flags of the elements are not cleared when collapsing a row. This
caused hover highlights and selections on the collapsed child icons to
be incorrect in many cases.

For example, only the direct children of a collapsed element are drawn
inline. If any grandchild elements had been previously icon row flagged
they would continue to be evaluated as icon row elements despite being
hidden. In this case the x coordinates of the child and grandchild would
overlap causing selection to appear erratic.

Now the flags for inline row icons are explicitly cleared, which was
previously only done because the tree was rebuilt on collapsing rows.

Fix T83801: UVEditor translation ignores "Pixel Coordinates" and aspect
ratio

Caused by rB4eda60c2d82d.

T83801 reported not moving in pixel space, but even without that toggle
above commit caused the translation to not take apsect ratio into
account properly [a translation of 1 on the x axis for example on an
image with non 1:1 aspect ration caused the UVs to not end up in the
same place on the next 'tile']

Above commit removed 'removeAspectRatio()' [the counterpart of
applyAspectRatio -- which does the pixel coord correction internally]
from 'applyTranslation()'.

This was also reported in T83352 [which was closed by rBf3b08af24c9f --
but that only solved the displax in header, not the actual
transformation]

Now bring back 'removeAspectRatio()'.

Maniphest Tasks: T83801

Differential Revision: https://developer.blender.org/D9869

Fix T83851: Python: operator macros cause a crash

Caused by rB7447eb7e7430.

This is just a copy-paste error [previous LISTBASE_FOREACH substitution
of marco loop in that file has a different starting point which is not
appropriate here]

Maniphest Tasks: T83851

Differential Revision: https://developer.blender.org/D9872

Fix T83875: Converting Proxy to override crashes blender.

Some weird proxies apparently can have a local collection instancing...
Not sure this is even really valid for proxies, but in any case we
cannot override that, just detect and properly cancel the operation
then.

Should be backported to 2.91.1 should we do it.

Fix crash sliding effect sequence strips

Off by one error in array access.

Fix T83361: UV Editor does not draw pinned selected UVs as pinned

Caused by rB4212b6528af.

outlineColor is computed by the vertex shader, so not a uniform.
So outlineColor was undefined.

note: it was still possible to run into the situation that a selected UV
is drawn ontop of a selected pinned UV [you had to disable sticky
selection for this], now also make sure selected-pinned are drawn
topmost, then selected, then unselected UVs.

Maniphest Tasks: T83361

Differential Revision: https://developer.blender.org/D9786

Fix T83296: Unknown actions no longer perform an undo push

str_len_clip is initialized to 0, so when "Unknown Action"
occurs, set str_len_clip appropriately.
Regression in 0688309988e546382748b9e755d84ae8a5059192

Ref D9759

Fix T83347: Smart UV project crashes with wire edges

Missing NULL check.
Regression in 9296ba867462f7ff3c55bc0c9129af4121243bed

Ref D9757

Revert "Fix T78823: Slash in custom property name does not work"

This reverts commit cbae82ba960a0baaae6437b176a310f078ce07d8.

This change introduced the following problems:

- We could no longer reliably duplicate or use an existing
custom property names.
- We could no longer assume a bone or ID name
can be used in a custom-property.
- Importers that support custom properties (such as FBX)
could fail with an exception creating custom properties.