Blender Git Loki

Cleanup: quiet warning -Wparentheses

Fix bl_app_override keyword argument use

D5737 by @cmporces

UI: Add extra file browser icons

Desktop, External Drive & Network Drive

These were already in the icon sheet, but not added in the Blender side.

Fix T69883: Deleting keyframe crashes blender

When delete in multiframe node the active frame gets NULL.

UI: Add XYZ mirroring to the Tool Settings viewport header for Edit and Weight Paint modes

Previously, only X mirror was available here, but since we can now mirror on Y and Z, these should also be added.

Industry Compat keymap: Use Ctrl/Cmd + Up/Left/Right for navigating the file browser in addition to Alt

Windows generally uses Alt, and Mac uses Cmd. This commit makes both possible.

Fix T69877: missing dependency update when setting PoseBone.custom_shape.

Sequencer: disable fades add/remove until eval() use is removed

2ec025d7be3ca9f3fd2fe0ac844ef70c69e7af55 introduced 'eval()' on blend
file data-paths which can be used for code injection.

fix: (unreported) When converting nurbs or curves to Mesh the generated UVMap is now named 'UVMap'

Cleanup: redundant code from recent sequence fade operator

No need to define class variables which are all overwritten,
also use __slots__ to avoid mistakes.

Remove redundant length check too.

Cleanup: remove duplicate information in docstring

No need to document all options in the doc-string
since each option has it's own description.

Cleanup: pep8, unused args, indentation

Cleanup: quiet unused arg warning

Cleanup: pep8

Quiet pylint warnings on keymaps.

macOS: Replaced deprecated Cocoa API calls.

Most of these calls were replaced with the successors as suggested
by Xcode's Fix-It. Functionality should not be affected.
This reduces the number of warnings when building on macOS.

macOS: Replaced OSSpinLock with os_unfair_lock.

OSSplinLock is a deprecated API, os_unfair_lock is its successor.
This reduces the number of warnings when building on macOS.

MSVC: Fix macro collision with MSVC Headers

Picked up while investigating a build error on the functions branch
which seems to use this specific header in a way master doesn't.

The problem:

The MSVC headers define a `_CONCAT` macro, so does BLI_kdtree_imp.h
however at the end `BLI_kdtree_imp.h` undefines the macro making the
MS headers that still rely on it "unhappy".

Who's fault is this:

Ours, C99 Spec says

```
7.1.3 Reserved identifiers

- All identifiers that begin with an underscore and either an uppercase letter or another underscore are always reserved for any use.

...

if the program removes (with #undef) any macro definition of an identifier in the first
group listed above, the behavior is undefined.
```

So we should not have defined it, and we definitely should not
have undefined it.

We have *tons* of these violations, although fixing them would be great
at one point lots of them are in /extern or in the 3rd party deps,
I'd rather deal with them on a case by case basis when it actually
causes issues.

Differential Revision: https://developer.blender.org/D5790

Reviewers: campbellbarton, JacquesLucke

Quiet self assignment warning

VSE: quiet missing prototype warnings

UI: quiet warning when drawing markers

The compiler was warning that it assumed that
crfa - 4 < cfra is always true even though that might not
be the case due to overflow. This patch just removes
the condition that caused the assumption.