Blender Git Loki

Fix T91629: Crash in "Open Cached Render" function

LibLink Append: Expose 'reuse ID' through new BLO flag, and add basic tests.

Option is now available to append operator, alsthough hidden and
disabled by default.

LibLink Append: Fix 'reused ID' case keeping linked data around.

When we re-use a local ID, we need to delete the matching linked data.

Cleanup: proper handling of `LIB_TAG_DOIT` in append code.

Cleanup: eBLOLibLinkFlags: Add 'space' between `APPEND` flags and `INSTANCE` ones.

Cleanup: Silence unused var warning in release builds.

Add missing GPencil `IDTYPE_FLAGS_APPEND_IS_REUSABLE` flag.

Forgot that one in rB794c2828af60.

Noted by Antonio Vazquez (@antoniov), thanks.

Append: Reuse local data: remove limitation on directly selected data.

in asset context, when user drag & drop a material several time, they
would still expect to re-use existing one instead of getting new copies
of it, even if this material is directly appended (and not an indirect
dependency of an object e.g.).

Link/Append: Refactor flags.

Flags controlling link/append code are split between two enums, one in
`DNA_space_types.h` and one in `BLO_readfile.h`.

This commit:
- Moves flags exclusively used in WM and BLO code to `eBLOLibLinkFlags`
in `BLO_readfile.h`. Flags in `eFileSel_Params_Flag` from
`DNA_space_types.h` are now only the ones effectively used by the
file browser editor code too.
- Fixes some internal utils in `readfile.c` still taking `short` flag
parameter instead of proper `int` one.

NOTE: there are a few other flags that could probably be moved to
`eBLOLibLinkFlags` (at the very least `FILE_LINK`, probably also
`FILE_AUTOSELECT` and `FILE_ACTIVE_COLLECTION`), since those are not
effectively used by the file browser, and control linking/appending
behavior, not filebrowser behavior.

However for now think it's safer to not touch that.

Fix last Cycles tile highlighted while file from disk is being processed

Fix default surface resolution U/V mis-match

The resolution for surfaces was 12 for U, 4 for V,
where both should have been set to 4.

Regression in 9a076dd95a01135ea50f9ccc675668db9f2155f4

Cleanup: spelling in comments

Custom Properties: Rewrite edit operator, improve UX

This commit changes the custom property edit operator to make editing
different properties types more obvious and expose more of the data,
made more easily possible by the recent UI data refactor.

Previously, the operator guessed the type you wanted based on what you
wrote in a text box. That was problematic, you couldn't make a string
property with a value of `1234`, and you had to know about the Python
syntax for lists in order to create an array property. It was also slow
and error prone; it was too easy to make a typo.

Improvements compared to the old operator:
- A type drop-down to choose between the property types.
- Step and precision values are exposed.
- Buttons that have the correct type based on the property.
- String properties no longer display min, max, etc. buttons.
- Generally works in more cases. The old operator tended to break.
- Choose array length with a slider.
- Easy to choose to use python evaluation when necessary.
- Code is commented, split up, and much easier to understand.

The custom property's value is purposefully not exposed, since the Edit
operator is for changing the property's metadata now, rather than the
value itself. Though in the "Python" mode the value is still available.

More improvements are possible in the future, like exposing different
subtypes, and improving the UI of the custom properties panel.

Differential Revision: https://developer.blender.org/D12435

Applying patch D12600, GSOC Knife Tools branch

This adds constrained angle mode improvements,
snapping to global and local orientation,
visible distance and angle measurements,
undo capability,
x-ray mode,
multi-object edit mode.

See https://developer.blender.org/D12600 for more details.

Note: this project moved some of the default keymappings
around a bit, as discussed with users in the thread
https://devtalk.blender.org/t/gsoc-2021-knife-tool-improvements-feedback/19047
We'll change the manual documentation in the next couple of days.

Fix: T91602 ffmpeg crash

Issue caused by our patch in rB1af722b81912
we replaced an array with a memory allocation
but we forgot to update the assert which now
used an invalid method to calculate the array
size.

SVN libs will have to be updated before
T91602 will be fixed for end users.

Cleanup: Move more shader nodes to socket declaration API

I had to add `no_muted_links` to the declaration API. The name could
change there, but I think it's more obvious than "internal"

Fix: Incorrect socket names after previous commit

Cleanup: Use new node socket declaration API for some shader nodes

This converts socket declarations for most shader nodes that had already
been converted to C++, but skips those that needed a special flag.

GPencil: Fix compiler warnings

Cleanup: Silence missing switch case warning