Blender Git Loki

OpenGL: convert old texture2D calls in FX shaders

And one texture1D call.

OpenGL: convert old texture2D calls in material GLSL

Modern GLSL simplifies texture sampling functions. Info about 1D, 2D, 3D, Cube, etc. comes from the sampler type.

Cycles: Fix compilation error after recent changes

Spotted by Steffen Dünner, thanks@

Remove redundant workaround for removing collections in outliner

Collections are now identified by their pointer.
Also had to correct TSE_IS_REAL_ID to fix undefined behavior on undo.

Fix crash when changing Clay "Edge Strength"

This was introduced by a removed line in
rB0eb32ab22809d9c0c41bfff5082f58b1a7aa9965

If we want to change the value to a differen default, it should be done
in a separated commit.

Fix crash opening really old files with compositor

There was lack of certain sockets do-versaions: namely the ones
which were added in blender versions after the one used to save
the file.

Fix crash when adding Torus in edit mode

Fix assert on framebuffer binding

Cleanup: add braces for multi-line blocks

Remove unused functions after WITH_LEGACY_OPENGL cleanup

Remove reference to WITH_LEGACY_OPENGL

We only keep this as a way to get GPU_stubs to run, in case we want to do a
throughout cleanup in the codebase and want code using legacy calls to
fail to build.

Remove reference to SUPPORT_LEGACY_MATRIX

Since the change to core profile this is no longer supported.

Remove reference to WITH_GL_PROFILE_CORE

There is no more point of keep those around. ES20 may need special case
when/if we dabble with it again. Meanwhile no point on polluting the
code with this.

(ghost still has reference for the PROFILE, but that's reasonable)

Correct core profile way of getting color depth

Cycles: Cleanup, always use parenthesis

Easier to read/follow, and more robust for the further changes.

Cycles: Cleanup, indentation in preprocessor

Cycles: Cleanup, variable names

Don't use camel case for variable names. Leave that for the structures.

Cycles: Cleanup, useless new lines

Cycles: Cleanup, braces after function definition

I wouldn't mind switching fully to Google style, but i am against of
mixing two different styles in same project. So just stick to brace
at the new line after function definition.

;115;0cCycles: Cleanup, use ccl_restrict instead of ccl_restrict_ptr

There were following issues with ccl_restrict_ptr:

- We already had ccl_restrict for all platforms.

- It was secretly adding `const` qualifier to the declaration,
which is quite weird since non-const pointer can also be
declared as restricted.

- We never in Blender are using foo_ptr or FooPtr type definitions,
so not sure why we should introduce such a thing here.

- It is absolutely wrong from semantic point of view to put pointer
into the restrict macro -- const is a part of type, not part of
hint for compiler that some pointer is never aliased.