Blender Git Loki

BMesh: Add 'cut' separate mode for intersect tool

It was only possible to separate all geometry from an intersection or none.

Made this into an enum with a 3rd option to 'Cut', (now default)
which keeps each side of the intersection separate
without splitting faces in half.

Fix T50855: Intersect (knife) w/o separate doesn't select

Fix T50843: Pitched Audio renders incorrectly in VSE

There was a bug in the intended code behaviour to always seek with a
pitch of 1.0 regardless of pitch/pitch animation/doppler effects.

Check the bug report for a more detailed explanation of problems
concerning pitch and seeking.

BLI_rect: add init from point functions

Initialize a rectangle from point+size.

OpenGL: remove fdrawcheckerboard

This helper function was marked DEPRECATED since it uses old OpenGL calls.

Switched last 2 uses to imm_draw_checker_box, which does the same thing, only awesome.

Part of T49043

Fix T50838: Surface Deform DM use after free issue

Implementd fix suggested by @sergey in T50838.

Cleanup: expose struct for ED_view3d_mats_rv3d_*

OpenGL: remove old DrawPixels util functions

a little bit of T49043, mostly related to T49165

Thx to @fclem for marking these as unused & making shader-based replacements.

OpenGL: remove glaDrawBorderCorners

This helper function was marked DEPRECATED since it uses old OpenGL calls.

Part of T49043

OpenGL: draw image render info with new imm mode (part 1)

Part of T49043

This was the last use of glaDrawBorderCorners.

Plenty more to do in this file, I'll keep working on it...

OpenGL: remove stipple pattern defines

GPU_basic_shader handles this internally; no other code depends on it.

OpenGL: remove glutil_draw_*_arc (lined, filled)

These helper functions were marked DEPRECATED since they use old OpenGL calls. Now they are marked GONE!

Part of T49043

OpenGL: paint_draw_cursor with new imm mode

Part of T49043.

This was the last use of glutil_draw_lined_arc.

Plenty more to do in this file, I'll keep working on it...

Gawain: fix for MSVC 2013

<stddef.h> defines offsetof. For some reason MSVC 2015 does not need this. Mystery!

OpenGL: remove fdrawbox, sdrawbox, sdrawline

These helper functions were marked DEPRECATED since they use old OpenGL calls. Now they are marked GONE!

Part of T49043

OpenGL: remove last uses of fdrawbox

Part of T49043

OpenGL: remove last uses of sdrawline & sdrawbox

Part of T49043

Fix own previous commit, sorry about that :(

Get rid of `BLI_task_pool_stop()`.

Comments said that function was supposed to 'stop worker threads', but
it absolutely did not do anything like that, was merely wiping out TODO
queue of tasks from given pool (kind of subset of what
`BLI_task_pool_cancel()` does).

Misleading, and currently useless, we can always add it back if we need
it some day, but for now we try to simplify that area.

Fix ugly mistake in BLI_task - freeing while some tasks are still being processed.

Freeing pool was calling `BLI_task_pool_stop()`, which only clears
pool's tasks that are in TODO queue, whithout ensuring no more tasks
from that pool are being processed in worker threads.

This could lead to use-after-free random (and seldom) crashes.

Now use instead `BLI_task_pool_cancel()`, which does waits for all tasks
being processed to finish, before returning.