Blender Git Loki

Cleanup: Remove unused next and prev pointers in bNodeType

Cleanup: Remove unnecesary node type draw callback

As a followup to 338c1060d5d7, apply the same change to the node
drawing callback. This helps to simplify code when the complexity
of a callback isn't necessary right now.

Cleanup: Remove unnecessary node type callbacks for drawing

Currently there are a few callbacks on `bNodeType` that do the same
thing for every node type except reroutes and frame nodes. Having a
callback for basic things complicates code and makes it harder to
understand, and reroutes and frames are special cases in larger way.

Arguably frame nodes shouldn't even be drawn like regular nodes,
given that it adds a case of O(N^2) looping through all nodes.
"Unrolling" the callbacks makes it easier to see what's happening,
and therefore easier to optimize.

Differential Revision: https://developer.blender.org/D13463

Cleanup: clang-tidy: modernize-redundant-void-arg

This change follows up on recent c --> c++ conversions

Cleanup: Add missing include

Fixes compilation errors after rBd5efda72f501
Re sorted some includes.

Cleanup: Migrate all shader nodes to c++

This will be useful in the future to use the new socket builder API

Aditional changes:

- Declare variables where initialized
- Do not use relative includes

Differential Revision: https://developer.blender.org/D13465

Geometry Nodes: use array instead of map in GeometrySet

`GeometrySet` contains at most one component of each type.
Previously, a map was used to make sure that each component
type only exists once. The overhead of a map (especially with
inline storage) is rather large though. Since all component types
are known at compile time and the number of types is low,
a simple `std::array` works as well.

Some benefits of using `std::array` here:
* Looking up the component of a specific type is a bit faster.
* The size of `GeometrySet` becomes much smaller from 192 to 40 bytes.
* Debugging a `GeometrySet` in many tools becomes simpler because
one can easily see which components exists and which don't

Fix (unreported): off-by-one error when setting curve handles

The problem is that `current_mask` can become `selection.size()`.
The loop could also be refactored to break out of it when the end
of the selection is reached. This can be done separately.

Compositor: Migrate most nodes to new socket builder API

This patch leaves a out a few nodes:

- Group Nodes
- Image input node
- File output node
- Switch View
- Cryptomatte

These nodes above are a bit more complicated and should be worked on individually.

Differential Revision: https://developer.blender.org/D13266

Create generic modal functions from GRAPH_OT_decimate

This patch extracts the modal functions from GRAPH_OT_decimate
and makes them generic so they can be reused by future operators

Reviewed by: Sybren A. St�vel
Differential Revision: https://developer.blender.org/D9326
Ref: D9326

Cleanup: Use LISTBASE_FOREACH macro

Cleanup: Use references in node editor, other improvements

This helps to tell when a pointer is expected to be null, and avoid
overly verbose code when dereferencing. This commit also includes
a few other cleanups in this area:
- Use const in a few places
- Use `float2` instead of `float[2]`
- Remove some unnecessary includes and old code
The change can be continued further in the future.

Cleanup: Remove unused code

This is very old and is unlikely to be useful in the near future.

Cleanup: Const, use references, C++ types

Also remove some unnecessary includes

Cleanup: Comments and ordering in node editor header

Cleanup: Use typed enum for node resize direction

ImBuf: Made Wrapping and Cropping optional in IMB_transform.

`IMB_transform` is used in VSE. It had a required crop parameter
for cropping the source buffer. This is not always needed.

In the image engine we want to use the use the `IMB_transform`
with wrap repeat. Both options are mutual exclusive and due
to performance reasons the wrap repeat is only available when
performing a nearest interpolation.

Cleanup: move public doc-strings into headers for 'bmesh'

Some minor improvements to doc-strings too.

Ref T92709

Fix T93541: Use warning instead of error for exceeding layer limits

Instead of using RPT_ERROR, use RPT_WARNING which will not raise an
exception to Python. This broke some scripts (including FBX import)
which already check for a None return value.

Ref D13458

Reviewed By: campbellbarton

Fix T93574: Asset triangulating a mesh

Correct assert for edit-mesh normal calculation.