Blender Git Loki

BGE: Cleanup KX_BlenderSceneConverter.cpp

This commit is a little cleanup for whitspaces, braces, spaces around operators and useless keywords struct/class.

Reviewers:sybren

Separate scene simplification into viewport and render

This way it is possible to have viewport simplification bumped all the way up,
making viewport really responsive but still have final render to use highest
subdivision possible.

Reviewers: lukastoenne, campbellbarton, dingto

Reviewed By: campbellbarton, dingto

Subscribers: dingto, nutel, eyecandy, venomgfx

Differential Revision: https://developer.blender.org/D1273

Skin Modifier: remove redundant edge-calculation

Fix T42893: Skin Modifier, changes randomly toggling editmode

Own regression, previously it would do a full mesh normal calculation for each isolated shape
(could hang on meshes with many loose parts).

However the normals are needed, instead of doing a full calculation,
just set normals on new faces.

Thanks to Brecht for finding cause!

Skin Modifier: Add missing operator stack pop

Fix metadata display in sequencer lost after doing a preprocess
transform.

IMB_makeSingleUser makes a copy and destroys metadata. I am not sure if
this is the safest way to make a single user ImBuf (setting the refcount
to 0 is simpler and there's less, but no zero, risk of dangling
pointers) but I will leave this as is for now in case there is an actual
need for a copy here. The alternative approach should be tested at some
point.

Freestyle: Fix for line style ID datablocks not copied when fully copying a scene.

Don't scale metadata font with zoom - makes strings not consistently
adhere to the string length

Support displaying metadata for images in sequencer preview windows (not
backdrop)

BGE Player: Fix compilation error after cleanup commit da8a62a

Fix T29029: Grease pencil fails in Quad View

Freestyle: Compilation error fix after recent changes in BKE_object_add()

CMake: Only consider it INFO is ld.gold is missing

Correct own error in recent quad-view ruler fix

Fix Buttons context, invalid object data access

Another instance of T44376.
Crash where the Python context would access a stale pointer to the active object.

Button Space: clear pin flag when NULL'ing pointer

Fix T44376: Buttons context, invalid data access

Removing a scene from the buttons window would crash from a Python operator.

Cleanup: WM_main_remove_notifier_reference

Assumed the `reference` pointer is an ID, currently true, but may not always be.
Add a callback specifically for this purpose since cleaning up notifiers and space-types are different operations.

Cleanup: naming for callback wrappers

Remove redundant outliner lookup freeing objects