Blender Git Commit Log

Git Commits -> Revision 06c5608

Revision 06c5608 by Bastien Montagne (master)
February 5, 2020, 14:51 (GMT)
Readfile: Proper fix for `recalc` flags clearing in non-real IDs

In current `readfile.c` code we have that:

https://developer.blender.org/diffusion/B/browse/master/source/blender/blenloader/intern/readfile.c$3523

This is unconditionally clearing nodetree's recalc flags, and was added by rB81a762e79f83 ages ago. Thing is, in main ID read code we only clear that flag when **not** in undo context.

This proposed change intends to properly handle those cases, by moving `id.recalc` flags clearing from `read_libblock()` to `direct_link_id()`, which is also called for all 'local' IDs (ntrees and master collections currently).

I?d expect that change to be straightforward (and maybe even fixing some odd undocumented bugs), however there is no .blend file testcases associated with changes in rB81a762e79f83, so wouldn?t mind that to be double checked before it goes to master.

Reviewed By: brecht

Differential Revision: https://developer.blender.org/D6711

Commit Details:

Full Hash: 06c560864607562acdc1e61b13369f24b22c102c
Parent Commit: ea2e699
Lines Changed: +12, -14

1 Modified Path:

/source/blender/blenloader/intern/readfile.c (+12, -14) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021