Blender Git Commit Log

Git Commits -> Revision 2ed6055

Revision 2ed6055 by Pablo Dobarro (master)
January 5, 2021, 19:23 (GMT)
Fix T79146: Sculpt Mode lags until the entire mesh is visible

This was caused when the BKE_pbvh_draw_cb function was used with
update_only_visible set to false. In that case, all nodes with the flag
were updating, but the update flag was only cleared for visible nodes.
This was causing constant updates per redraw in no visible nodes until
they enter the view frustum and their flag was cleared.

In order to fix this and prevent it from happening again:
- Updating the buffers, flushing the updates and clearing the flags are
now part of the same function. It does not make sense to do these in
separate places.

- The BKE_pbvh_draw_cb function was refactored so the
pbvh_update_draw_buffers is only called once. It should now be easier to
understand what the function does when it is used to update only visible
nodes or all nodes.

Reviewed By: mont29

Maniphest Tasks: T79146

Differential Revision: https://developer.blender.org/D9935

Commit Details:

Full Hash: 2ed605520959eca9c0ab3c497c85578e138936b4
Parent Commit: c20e482
Lines Changed: +30, -33

1 Modified Path:

/source/blender/blenkernel/intern/pbvh.c (+30, -33) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021