Blender Git Commit Log

Git Commits -> Revision 3b4f699

Revision 3b4f699 by Bastien Montagne (master)
October 12, 2017, 12:50 (GMT)
Fix T52999: floating (popup) panels/menus could jump around screen in some cases.

Would happen during panel's refresh drawing, if drawing code had to adjust
final panel position compared to the initial one computed based on the
mouse coordinates, and user had dragged the floating panel around.

Issue fixed by adjusting stored mouse coordinates once final panel
position is known, such that they would directly generate those
coordinates. that way, the basic offset applied to those stored mouse
coordinates during panel dragging is valid, and recreating panel based
on those won't make it jump in screen.

Note that panel will still jump in case user dragged it partially out of
view - we could prevent that, but imho it's better to keep that
behavior, since redraw can generate a popup of different size, which
could end up with a totally out-of-view one...

Hopefully this fix does not break anything else!

Commit Details:

Full Hash: 3b4f6996a8fd521b532eff0f8cbcd282d9a2c5b7
Parent Commit: b29e37e
Lines Changed: +18, -10

3 Modified Paths:

/source/blender/editors/include/UI_interface.h (+1, -1) (Diff)
/source/blender/editors/interface/interface.c (+14, -7) (Diff)
/source/blender/editors/interface/interface_regions.c (+3, -2) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021