Blender Git Commit Log

Git Commits -> Revision 3e1a9ee

Revision 3e1a9ee by Kévin Dietrich (master)
November 22, 2015, 17:18 (GMT)
Smoke drawing code cleanups (and little refactor)

This patch contains the following changes:

- the vertices and edges arrays would be assigned default values, and
then reassigned new ones right away. It appears that those arrays were
once global and then made local
(rB06a2ee4afed4237398b69ddf253e29a730b2f9f0), so it makes sense now to
initialize them with the right values.
- the flame spectrum texture was created whether it was needed or not,
so now it's only created if there's flame to be drawn, also split the
code in a separate function.
- reduce the number of parameters to the main draw function, as most of
them are member of SmokeDomainSettings.
- some other minor cleanups: fold multiple operations into one to get
rid of one local variable, mark variables as `const` when necessary,
unecessary gl draw calls, reorder the code a bit...

Reviewers: campbellbarton, psy-fi

Differential Revision: https://developer.blender.org/D1368

Commit Details:

Full Hash: 3e1a9ee386b054912b540b7a061d76235f4049fa
Parent Commit: 8623d75
Lines Changed: +108, -171

3 Modified Paths:

/source/blender/editors/space_view3d/drawobject.c (+4, -10) (Diff)
/source/blender/editors/space_view3d/drawvolume.c (+102, -158) (Diff)
/source/blender/editors/space_view3d/view3d_intern.h (+2, -3) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021