Blender Git Commit Log

Git Commits -> Revision 44d2479

Revision 44d2479 by Jeroen Bakker (master)
May 31, 2021, 15:11 (GMT)
Refactor: DRW Mesh Extractor: Join the extractors in a same loop

This patch replaces / redoes the entire MeshExtractors system.
Although they were useful and facilitated the addition of new buffers, they made it difficult to control the threads and added a lot of threading overhead.

Part of the problem was in traversing the same loop type in different threads. The concurrent access of the BMesh Elements slowed the reading.

This patch simplifies the use of threads by merging all the old callbacks from the extracts into a single series of iteration functions.

The type of extraction can be chosen using flags.

This optimized the process by around 34%.

Initial idea and implementation By @mano-wii.
Fine-tuning, cleanup by @atmind.

MASTER:
large_mesh_editing:
- rdata 9ms iter 50ms (frame 155ms)
- Average: 6.462874 FPS

PATCH:
large_mesh_editing:
- rdata 9ms iter 34ms (frame 136ms)
- Average: 7.379491 FPS

Differential Revision: https://developer.blender.org/D11425

Commit Details:

Full Hash: 44d2479dc36fe3409afc660eea369bea8a517987
Parent Commit: aebeb85
Lines Changed: +1527, -1251

6 Modified Paths:

/source/blender/draw/intern/draw_cache_extract.h (+1, -1) (Diff)
/source/blender/draw/intern/draw_cache_extract_mesh.c (+1513, -1243) (Diff)
/source/blender/draw/intern/draw_cache_impl_curve.cc (+6, -0) (Diff)
/source/blender/draw/intern/draw_cache_impl_displist.c (+4, -0) (Diff)
/source/blender/draw/intern/draw_cache_impl_mesh.c (+3, -3) (Diff)
/source/blender/draw/intern/draw_cache_inline.h (+0, -4) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021