Blender Git Commit Log

Git Commits -> Revision 594656e

Revision 594656e by Hans Goudey (master)
December 2, 2021, 02:16 (GMT)
Fix T93525: Crash with curve/text armature bone gizmo

The problem is that drw_batch_cache_generate_requested_delayed
is called on the object, which uses the original object data type to
choose which data type to get info for. So for curves and text it uses
the incorrect type (not the evaluated mesh like we hardcoded in the
armature overlay code).

To fix this I hardcoded the "delayed" generation to only use the
evaluated mesh. Luckily it wasn't use elsewhere besides this
armature overlay system. That seems like the simplest fix for
3.0. A proper solution should rewrite this whole area anyway.

Differential Revision: https://developer.blender.org/D13439

Commit Details:

Full Hash: 594656e7a39d3598d7a357511742fb0b001254bc
Parent Commit: 9cec9b4
Lines Changed: +33, -4

4 Modified Paths:

/source/blender/draw/engines/overlay/overlay_armature.c (+7, -3) (Diff)
/source/blender/draw/intern/draw_cache.c (+19, -0) (Diff)
/source/blender/draw/intern/draw_manager.c (+2, -1) (Diff)
/source/blender/draw/intern/draw_manager.h (+5, -0) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021