Blender Git Commit Log

Git Commits -> Revision 5f0933f

Revision 5f0933f by Bastien Montagne (master)
October 27, 2016, 11:06 (GMT)
Fix T49829: Removal of custom icon previews during add-on unregister crashes Blender.

Issue was happening when removal of custom icons was done while they
were still being rendered by preview job.

Now add a 'deffered deletion' system, to prevent main thread to delete
preview image until loading thread is done with them.

Note that ideally, calling `ED_preview_kill_jobs()` on custom icon
removal would have been simpler, but we don't have easy access to
context here...

Commit Details:

Full Hash: 5f0933f07a548719a850d9cac01aae6709b9dc0b
Parent Commit: f112986
Lines Changed: +54, -14

6 Modified Paths:

/source/blender/blenkernel/BKE_icons.h (+1, -0) (Diff)
/source/blender/blenkernel/intern/icons.c (+15, -5) (Diff)
/source/blender/blenloader/intern/readfile.c (+1, -0) (Diff)
/source/blender/editors/interface/interface_icons.c (+1, -1) (Diff)
/source/blender/editors/render/render_preview.c (+26, -5) (Diff)
/source/blender/makesdna/DNA_ID.h (+10, -3) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021