Blender Git Commit Log

Git Commits -> Revision 71a2ff1

Revision 71a2ff1 by Sergey Sharybin (master)
April 4, 2014, 06:46 (GMT)
Fix crash happening in DAG_pose_sort() due to threading issues

This function used ugly hack with static variable which was
preventing some type checks in DAG nodes. Using this variable
form multiple threads is not considered safe, apparently.

Solved by moving this variable inside the DAGForest structure.
so it's global for the graph now, but different graphs does not
run into conflicts.

This required passing the forest to some functions, which doesn't
look so much nice, but don't want to spend time on making this
code look beautiful because it is really to be replaced by the
new dependency graph.

This is really bad bug actually which is must go to 'a'.

Commit Details:

Full Hash: 71a2ff12a81bbe2a05ae83056bcb107e211265f2
Parent Commit: 45b02ce
Lines Changed: +20, -21

4 Modified Paths:

/source/blender/blenkernel/BKE_depsgraph.h (+1, -1) (Diff)
/source/blender/blenkernel/depsgraph_private.h (+1, -0) (Diff)
/source/blender/blenkernel/intern/depsgraph.c (+17, -19) (Diff)
/source/blender/blenkernel/intern/scene.c (+1, -1) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021