Blender Git Commit Log

Git Commits -> Revision 71f6898

Revision 71f6898 by Sergey Sharybin (master)
January 1, 2014, 16:32 (GMT)
Fix deadlock happening when using Save Buffers for render

Summary:
Issue was caused by the same tile being written twice to
the EXR file. This was happening because of partial update
of work-in-progress tiles was merging result to the final
render result in order to make color management pipeline
happy.

We need to avoid such a merges and keep memory usage as
low as possible when Save Buffers is enabled.

Now render pipeline will allocate special display buffer
in render layer which will contain combined pass in the
display space. This keeps memory usage as low as we can
do at this moment.

There's one weak thing which is changing color management
settings during rendering would lead to lossy conversion.
This is because render result's display buffer uses color
space from the time when rendering was invoked.

This is actually what was happening in previous release
already actually so not a big issue.

Reviewers: brecht

Reviewed By: brecht

Differential Revision: https://developer.blender.org/D162

Commit Details:

Full Hash: 71f689843d13b86fad26ab07867ea70fed80c1e7
Parent Commit: 549248f
Lines Changed: +154, -59

8 Modified Paths:

/source/blender/blenkernel/intern/image.c (+29, -0) (Diff)
/source/blender/compositor/operations/COM_ViewerOperation.cpp (+1, -1) (Diff)
/source/blender/editors/render/render_internal.c (+54, -26) (Diff)
/source/blender/imbuf/IMB_colormanagement.h (+7, -2) (Diff)
/source/blender/imbuf/intern/colormanagement.c (+48, -28) (Diff)
/source/blender/render/extern/include/RE_pipeline.h (+2, -0) (Diff)
/source/blender/render/intern/source/external_engine.c (+10, -2) (Diff)
/source/blender/render/intern/source/render_result.c (+3, -0) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021