Blender Git Commit Log

Git Commits -> Revision 8730984

Revision 8730984 by Bastien Montagne (master)
March 8, 2019, 16:53 (GMT)
Fix (unreported) datatransfer code could still modify source mesh in some cases.

Source (i.e. other) mesh should not be modified in any case in modifier
evaluation case (this is forbidden by design and can lead to all kind of
threaded locks and crashes), and doing so even in operator case was
never a good idea either.

Now that we can specifically request needed data (poly and/or loop
normals) from evaluation code, we can finally get rid of those
computations inside data transfer/mesh remapping area.

This is hopefully the last remaining bit of this 'bad crashing code' in
datatransfer area.

Commit Details:

Full Hash: 8730984c708bdde6a2cf29fc4f29bd50c05b349c
Parent Commit: cdba2bc
Lines Changed: +11, -12

3 Modified Paths:

/source/blender/blenkernel/intern/data_transfer.c (+7, -5) (Diff)
/source/blender/blenkernel/intern/mesh_remap.c (+2, -7) (Diff)
/source/blender/modifiers/intern/MOD_datatransfer.c (+2, -0) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021