Blender Git Commit Log

Git Commits -> Revision 88a5380

Revision 88a5380 by Sergey Sharybin (master)
August 29, 2011, 16:07 (GMT)
Fix #28347: VBO's highlights wrong faces when Mirror modifier is in use

Added callback to drawMappedFaces which checks if two faces have got equal draw options.

After discussion with Brecht we found it's nicest solution for now:
- Disabling VBOs in edit mode for this case wouldn't be nicer for this case -
some additional flag stored in DM should be added in this case.
- Adding new callback in DM isn't nicer that this solution.
- Handling face selection in drawobject would lead to duplicated code
which is also not nice.

Hopefully, this callback could handle all cases in the future.

Also, Brecht mentioned current VBO implementation isn't perfect, so maybe
when we'll redesign this area dealing with edit mode wouldn't be so tricky.

Commit Details:

Full Hash: 88a538048bf7671db6a51fa2791ed1c87fa88611
SVN Revision: 39777
Parent Commit: 6cf447a
Lines Changed: +71, -21

6 Modified Paths:

/source/blender/blenkernel/BKE_DerivedMesh.h (+2, -1) (Diff)
/source/blender/blenkernel/intern/cdderivedmesh.c (+25, -6) (Diff)
/source/blender/blenkernel/intern/DerivedMesh.c (+5, -1) (Diff)
/source/blender/blenkernel/intern/subsurf_ccg.c (+5, -1) (Diff)
/source/blender/editors/space_view3d/drawmesh.c (+1, -1) (Diff)
/source/blender/editors/space_view3d/drawobject.c (+33, -11) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021