Blender Git Commit Log

Git Commits -> Revision 95e010a

Revision 95e010a by Szymon Ulatowski (master)
April 12, 2021, 12:42 (GMT)
Fix T74680: Incorrect mixing in Glare node

The mixing function was designed to give correct results for Mix values of
-1, 0, and +1, but the behavior between these points was not linear. This is
unavoidable, because the function depends on both Mix and Mix^2 (by
multiplying value and mf) so they could not cancel out completely.

The new formula simply calculates the weighted sum without trying to invent
a smooth function.
Value for MixGlareOperation is now passed directly without scaling because
it is then easier to use.
Note that the previous formula performed max() twice for both input image
and the result, now there is just one max() per channel because the glare
input can't be negative.

Reviewed By: jbakker

Differential Revision: https://developer.blender.org/D7138

Commit Details:

Full Hash: 95e010a22eb422a1efa2f7e2bbb6b3ee168ce9e5
Parent Commit: 53f277a
Committed By: Jeroen Bakker
Lines Changed: +14, -15

By: Miika HämäläinenLast update: Nov-07-2014 14:18 MiikaHweb | 2003-2021