Blender Git Commit Log

Git Commits -> Revision a425b2b

Revision a425b2b by Manuel Castilla (master)
April 14, 2021, 06:18 (GMT)
Fix (unreported) compositor resolution propagation broken by some nodes

Some operations may use no preferredResolution ({0, 0}) when calling determineResolution on inputs to check if they have resolution on their own. See MixOperation or MathOperation determineResolution implementation. In such cases {0, 0} resolution ends up being set when an input doesn't have own resolution, breaking propagation of the original preferredResolution. They don't mean to set it as resolution, it's just a check.

This patch only allows to set valid resolutions (>0). When it's 0 it may be understood as "No preferred or determined resolution" so it should not be set to give output operations another chance of finding a proper resolution by calling determineResolution again with a different preferredResolution.

Test file:
{F9932526}

Reviewed By: #compositing, jbakker

Differential Revision: https://developer.blender.org/D10972

Commit Details:

Full Hash: a425b2b25c0f7ba44e9732633e648338270c4483
Parent Commit: 6776b74
Committed By: Jeroen Bakker
Lines Changed: +3, -1

1 Modified Path:

/source/blender/compositor/intern/COM_NodeOperation.cc (+3, -1) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021