Blender Git Commit Log

Git Commits -> Revision ac28b34

Revision ac28b34 by Hans Goudey (lineart-shadow)
December 8, 2021, 06:53 (GMT)
Cleanup: Remove unnecessary node type callbacks for drawing

Currently there are a few callbacks on `bNodeType` that do the same
thing for every node type except reroutes and frame nodes. Having a
callback for basic things complicates code and makes it harder to
understand, and reroutes and frames are special cases in larger way.

Arguably frame nodes shouldn't even be drawn like regular nodes,
given that it adds a case of O(N^2) looping through all nodes.
"Unrolling" the callbacks makes it easier to see what's happening,
and therefore easier to optimize.

Differential Revision: https://developer.blender.org/D13463

Commit Details:

Full Hash: ac28b34f4f5325cb2f04a550e76da5cba26c71e9
Parent Commit: 15850ce
Committed By: YimingWu
Lines Changed: +141, -200

6 Modified Paths:

/source/blender/blenkernel/BKE_node.h (+0, -21) (Diff)
/source/blender/editors/space_node/drawnode.cc (+30, -141) (Diff)
/source/blender/editors/space_node/node_draw.cc (+91, -29) (Diff)
/source/blender/editors/space_node/node_edit.cc (+1, -1) (Diff)
/source/blender/editors/space_node/node_intern.hh (+10, -2) (Diff)
/source/blender/editors/space_node/node_select.cc (+9, -6) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021