Blender Git Commit Log

Git Commits -> Revision c9eef24

Revision c9eef24 by Lukas Stockner (master)
January 17, 2019, 23:58 (GMT)
Fix T56799: Custom render passes missing when using Save Buffers

The problem here was that when a render result is allocated, the standard render passes are added according to the
pass bitfield. Then, when the render engine sets the result, it adds the additional passes which are then merged
into the main render result.

However, when using Save Buffers, the EXR is created before the actual render starts, so it's missing all those
additional passes.

To fix that, we need to query the render engine for a list of additional passes so they can be added before the EXR
is created. Luckily, there already is a function to do that for the node editor.

The same needs to be done when the EXR is loaded back.

Due to how that is implemented though (Render API calls into engine, engine calls back for each pass), if we have
multiple places that call this function there needs to be a way to tell which one the call came from in the pass
registration callback. Therefore, the original caller now provides a callback that is called for each pass.

Commit Details:

Full Hash: c9eef24903479a70783efb2e00766d0eeec43823
Parent Commit: af316e8
Lines Changed: +93, -35

7 Modified Paths:

/source/blender/nodes/composite/nodes/node_composite_image.c (+16, -1) (Diff)
/source/blender/render/extern/include/RE_engine.h (+11, -0) (Diff)
/source/blender/render/intern/include/render_result.h (+4, -3) (Diff)
/source/blender/render/intern/source/envmap.c (+1, -1) (Diff)
/source/blender/render/intern/source/external_engine.c (+30, -22) (Diff)
/source/blender/render/intern/source/pipeline.c (+4, -4) (Diff)
/source/blender/render/intern/source/render_result.c (+27, -4) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021