Blender Git Commit Log

Git Commits -> Revision ca2484e

Revision ca2484e by Sergey Sharybin (master)
April 12, 2018, 09:05 (GMT)
Depsgraph: Remove function bindings with collections

Use single function to evaluate all the collections for the given view layer.

This way we avoid need to get scene ID sub-data. Similar to pchan index, this
allows us to avoid build-time scene expansion, which also simplifies update of
the scene datablock.

Well, sort of. There is still work to be done to get rid of build-time scene
datablock expansion, which includes:

- Need to pass view layer by index.

Annoying part would be to get actual view layer for that index. In practice
doing list lookup might not be such a bad idea, since such lookup will not
happen very often, and it is unlikely to have more than handful of view
layer anyway.

Other idea could be to use view layer from evaluation context.
Or maybe from depsgraph, which is supposed to be in the context. Can have
some assert statements to make sure everything is good.

- Need to get id of base binding for flags flush.

We can replace that with index-based lookup from an array created by view
layer evaluation.

Reviewers: dfelinto

Differential Revision: https://developer.blender.org/D3141

Commit Details:

Full Hash: ca2484e09005207e7bad90f484de6cbba1013833
Parent Commit: c168090
Lines Changed: +48, -328

2 Deleted Paths:

/source/blender/depsgraph/intern/builder/deg_builder_nodes_layer_collection.cc (+0, -126)
/source/blender/depsgraph/intern/builder/deg_builder_relations_layer_collection.cc (+0, -124)

13 Modified Paths:

/source/blender/blenkernel/BKE_layer.h (+3, -8) (Diff)
/source/blender/blenkernel/intern/group.c (+1, -25) (Diff)
/source/blender/blenkernel/intern/layer.c (+33, -7) (Diff)
/source/blender/depsgraph/CMakeLists.txt (+0, -2) (Diff)
/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc (+1, -1) (Diff)
/source/blender/depsgraph/intern/builder/deg_builder_nodes.h (+0, -11) (Diff)
/source/blender/depsgraph/intern/builder/deg_builder_nodes_view_layer.cc (+7, -1) (Diff)
/source/blender/depsgraph/intern/builder/deg_builder_relations.cc (+1, -1) (Diff)
/source/blender/depsgraph/intern/builder/deg_builder_relations.h (+0, -14) (Diff)
/source/blender/depsgraph/intern/builder/deg_builder_relations_view_layer.cc (+0, -2) (Diff)
/source/blender/depsgraph/intern/depsgraph_tag.cc (+2, -2) (Diff)
/source/blender/depsgraph/intern/depsgraph_types.h (+0, -2) (Diff)
/source/blender/depsgraph/intern/depsgraph_type_defines.cc (+0, -2) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021