Blender Git Commit Log

Image cache rewrite to using generic movie cache

Summary:
Behaves very much the same as cache for Movie Clip datablock:

- Image now have `MovieCache *cache` field which replaced
legacy `ListBase ibufs`.

This allows image datablock to easily keep of image
buffers which are owned by itself. This field isn't
saved to the file and getting restored on undo steps.

However, cache limit is global for movies, sequences
and image datablocks now. So overall cached image buffers
size will not go above cache limit size in user
preferences.

- Image buffers which are marked as BITMAPDIRTY will never
be freed from the cache.

- Added utility function to iterate over image buffers
saved in movie cache.

- Movie cache cleanup check callback now have ImBuf argument
which can be used in a condition of cleanup.

- Added some utility functions which replaces legacy ibufs
iterations with image cache iteration which happens from
inside a lock.

- Fixed `image_mem_size()` which was only counting one of
the buffers if both float and byte buffer present.

Additional notes:

- `BKE_image_get_first_ibuf()` is rather stupid, but direct
access to ibufs->first was also the same stupid idea.

Would consider avoid this function is another project.

- There are some places which doesn't look threadsafe, but
they already were not so much threadsafe anyway before.

So think not a big deal with solving this later.

Finally solves infinite memory usage by image sequences! :)

Reviewers: brecht, campbellbarton

Reviewed By: brecht

CC: sebastian_k

Differential Revision: https://developer.blender.org/D95