Blender Git Commit Log

Git Commits -> Revision d631252

Revision d631252 by Sergey Sharybin (master)
January 24, 2016, 20:25 (GMT)
Fix lock release deadlock when acquiring pass with no data ready yet

There is no reason to do separate image buffer release when there's
found buffer but with empty rects because of the following reasons:

- All the acquire() calls are followed with corresponding release()
calls, regardless of whether image buffer was empty, missing or
whatever.

- It was done wrong -- since lock was passed as NULL, it'll only
de-reference the image buffer itself, this causes following:

* Wrong user counter since there'll subsequent release() call with
the proper lock passed to it.
* Global locks are to be released prior to the spin locks,
and such an extra release violated this rule.

Commit Details:

Full Hash: d631252109bea2e69dae67686b1b8611b52a670d
Parent Commit: a224ee0
Lines Changed: +0, -2

1 Modified Path:

/source/blender/editors/space_image/image_edit.c (+0, -2) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021